Improvement: Refactor code to use dict.get() method

[codesankalp]

Description

As a developer,
I need code to be consistent and error-free.

Mocks

mentorship-backend/app/api/dao/user.py

Lines 42 to 46 in d52d777

	name = data["name"]
	username = data["username"]
	password = data["password"]
	email = data["email"]
	terms_and_conditions_checked = data["terms_and_conditions_checked"]

For example this can be replaced by the get method i.e. data.get("KEY", "DEFAULT_VALUE") to avoid KeyError

Acceptance Criteria

Update [Required]

• Use get method in all code to avoid the raise of KeyError
• Handle exceptions for default value

Definition of Done

• All of the required items are completed.
• Approval by 1 mentor.

Estimation

2 hours

[harsh7in]

hey @codesankalp can i work on this ?

[codesankalp]

Sure @harsh-9in 😄. Assigning you!

[vj-codes]

@codesankalp hey was this issue update discussed anywhere?

[codesankalp]

@vj-codes This is the referenced comment: anitab-org/stem-diverse-tv#146 (comment)

[isabelcosta]

@vj-codes thank you for confirming it! I saw the issue being created on stem diverse and thought it could be a little improvement here :)

cc @codesankalp

[vj-codes]

@harsh-9in any updates on this?

[vj-codes]

@harsh-9in if you have any questions about the issue or setting up the project, you can ask us here in comments or on zulip too :)

[aakankshaagr]

@vj-codes Can I work on this issue?

[epicadk]

@codesankalp I don't get this? Why would we need a default value here? The data that comes from the user is already validated and needs to have these keys.

[codesankalp]

@codesankalp I don't get this? Why would we need a default value here? The data that comes from the user is already validated and needs to have these keys.

Yes, it is but when you see the code there is a lot of repetition of code for validation which can be reduced using dict.get()

In the description, I just gave the example of dao/user.py but what I want to convey is to use dict.get method wherever necessary so that code doesn't look repetitive.

Example:

mentorship-backend/app/api/dao/user.py

Lines 244 to 248 in 25d8d99

	if "bio" in data:
	if data["bio"]:
	user.bio = data["bio"]
	else:
	user.bio = None

This can be written as:
data.get("bio", None)

This needs to be changed in the whole code.

[aakankshaagr]

@vj-codes @epicadk @codesankalp I have created a PR. Please check, if any changes are required.
Run tests are failing due to black (formatting issue) and I don't know the command for that. Can someone please tell me the command to remove that issue?