Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use sql alchemy events to validate data #1083

Open
epicadk opened this issue Apr 29, 2021 · 2 comments · May be fixed by #1096
Open

Use sql alchemy events to validate data #1083

epicadk opened this issue Apr 29, 2021 · 2 comments · May be fixed by #1096
Assignees
@epicadk
Labels
Category: Coding Changes to code base or refactored code that doesn't fix a bug. Type: Maintenance Repository maintenance.

Comments

@epicadk
Copy link
Member

epicadk commented Apr 29, 2021

Is your feature request related to a problem? Please describe.

Currently we do not validate data before sending it to the database

Describe the solution you'd like

Use the sql alchemy before insert even to validate the data being stored in the database
@epicadk epicadk added Status: Available Issue was approved and available to claim or abandoned for over 3 days. Category: Coding Changes to code base or refactored code that doesn't fix a bug. Type: Maintenance Repository maintenance. labels Apr 29, 2021
@epicadk
Copy link
Member Author

epicadk commented Apr 29, 2021

Marking this as available because it's not really changing any functionality. But if @anitab-org/mentorship-maintainers think it's not required then will close.

@epicadk
Copy link
Member Author

epicadk commented May 8, 2021

I'd like to work on this.

@devkapilbansal devkapilbansal removed the Status: Available Issue was approved and available to claim or abandoned for over 3 days. label May 8, 2021
@epicadk epicadk linked a pull request May 8, 2021 that will close this issue
Open
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@epicadk epicadk

Labels
Category: Coding Changes to code base or refactored code that doesn't fix a bug. Type: Maintenance Repository maintenance.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat : add validations epicadk/mentorship-backend
2 participants
@devkapilbansal @epicadk