Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug: Tests run more than once in Gtihub Actions #1093

Open
devkapilbansal opened this issue May 5, 2021 · 4 comments · May be fixed by #1095
Open

Bug: Tests run more than once in Gtihub Actions #1093

devkapilbansal opened this issue May 5, 2021 · 4 comments · May be fixed by #1095
Assignees
@devkapilbansal
Labels
Category: Quality Assurance Changes to code or files that improve testing or fixes bugs. Type: Bug Bug or Bug fixes.

Comments

@devkapilbansal
Copy link
Member

Describe the bug

In workflow, tests are mentioned more than once to run. This is causing wastage of resources(although we get it for free) and time.

To Reproduce

Steps to reproduce the behavior:

  1. Go to Actions
  2. Click on any recent workflow
  3. Go to build workflow
  4. Scroll down to tests
  5. See tests running more than once

Expected behavior

Tests should run only once

Additional context

The same was discussed on zulip some time ago where a solution was also proposed
@devkapilbansal devkapilbansal added Category: Quality Assurance Changes to code or files that improve testing or fixes bugs. Type: Bug Bug or Bug fixes. labels May 5, 2021
@devkapilbansal
Copy link
Member Author

@isabelcosta once approved if no one takes the issue, I will make a PR for it

@epicadk
Copy link
Member

epicadk commented May 5, 2021

Oh oops sorry assigned by mistake. It is a valid issue btw do you want to work on it?

@devkapilbansal
Copy link
Member Author

Oh oops sorry assigned by mistake. It is a valid issue btw do you want to work on it?

I can

@devkapilbansal
Copy link
Member Author

Will open a PR by today

@devkapilbansal devkapilbansal linked a pull request May 7, 2021 that will close this issue
Open
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@devkapilbansal devkapilbansal

Labels
Category: Quality Assurance Changes to code or files that improve testing or fixes bugs. Type: Bug Bug or Bug fixes.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: Fixed tests running more than once and minor improvements devkapilbansal/mentorship-backend
2 participants
@devkapilbansal @epicadk