-
Notifications
You must be signed in to change notification settings - Fork 449
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change the Comments API to provide the user details along with the comments #1110
Comments
Hello there!👋 Welcome to the project!💖 Thank you and congrats 🎉 for opening your very first issue in this project. You may submit a PR on the same if you like! Also, feel free to join us on AnitaB.org Open Source Zulip Community 🤝 We have different streams for each active repository for discussions.👩🏻💻🧑🏻💻 |
@justdvnsh do you want to work on this? |
@epicadk I don't think I'd be able to work on this. Would not be able to give in the time for this issue. |
@epicadk can I try working on this? |
@justdvnsh can you tell me the exact endpoint you want changed? |
@justdvnsh @epicadk
|
Sure that works or you could change the comment response to include the corresponding user within the comment. I think this way makes more sense. |
@epicadk but wouldn't that be sending a lot of redundant information? Since there are only 2 users involved, I'd be sending the same info over and over again. Response might become unnecessarily big. |
Duplicate issue #685 |
Is your feature request related to a problem? Please describe.
The comment API right now provides the userID as a parameter in the response. It needs to change to provide the user details such as username and email along with the comment response. A complete discussion can be found here. anitab-org/mentorship-android#1129
Describe the solution you'd like
User details come along with the comments response
Additional context
A complete discussion can be found here. anitab-org/mentorship-android#1129
The text was updated successfully, but these errors were encountered: