Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Require mentor's approval for task completion #278

Open
bartekpacia opened this issue Dec 15, 2019 · 7 comments · May be fixed by #1130
Open

Require mentor's approval for task completion #278

bartekpacia opened this issue Dec 15, 2019 · 7 comments · May be fixed by #1130
Assignees
@RiddhiAthreya
Labels
Category: Coding Changes to code base or refactored code that doesn't fix a bug. Type: Enhancement New feature or request.

Comments

@bartekpacia
Copy link
Contributor

bartekpacia commented Dec 15, 2019 •
edited
Loading

Is your feature request related to a problem? Please describe.
This was first raised by asawesome07 in this PR.
What he suggests is adding a new feature: in a specific mentorship relatio, the user can't mark the task as completed himself - he needs the mettor's approval.

Describe the solution you'd like
I think the best solution is to add a new property to relation data model. This property would indentify whether mentee can mark tasks as completed by himself or needs a mentor to approve task completion.

This property could be named [for example] requires_approval: [boolean]

It would default to false when the relation is created. After that, only mentor would be able to change it.

Describe alternatives you've considered
I think the above is the simplest solution, but there might be a better one I'm not aware of.
@isabelcosta
Copy link
Member

Good idea @bartekpacia 🎉 I think that has crossed my mind during the GSoC program, but for the sake of having a minimum functional product, I think we decided to simplify there. This is a great idea to think now :)

There could be something added to the task model. Here's what is exposed by the API:

{
  "id": 0,
  "description": "string",
  "is_done": true,
  "created_at": 0,
  "completed_at": 0
}

To facilitate brainstorming this issue

@isabelcosta isabelcosta added Category: Coding Changes to code base or refactored code that doesn't fix a bug. Status: Available Issue was approved and available to claim or abandoned for over 3 days. Type: Enhancement New feature or request. labels Dec 15, 2019
@bartekpacia
Copy link
Contributor Author

Great, I'll try to look into in when I finish implementing CLI :)

@bartekpacia bartekpacia mentioned this issue Dec 17, 2019
Closed
8 tasks
@bartekpacia
Copy link
Contributor Author

Aaaand...done:D

@vermastuti
Copy link
Contributor

Is this issue resolved?

@bartekpacia
Copy link
Contributor Author

bartekpacia commented Feb 21, 2021 •
edited
Loading

I did it long time ago in #292, but can't bring that branch up to date with master right now

@vj-codes vj-codes removed the Status: Available Issue was approved and available to claim or abandoned for over 3 days. label Mar 9, 2021
@vj-codes vj-codes added the Status: Available Issue was approved and available to claim or abandoned for over 3 days. label Mar 17, 2021
@RiddhiAthreya
Copy link
Contributor

@vj-codes can I work on this?

@vj-codes
Copy link
Member

vj-codes commented Jul 2, 2021

Assigning you @RiddhiAthreya
Happy coding!

@vj-codes vj-codes removed the Status: Available Issue was approved and available to claim or abandoned for over 3 days. label Jul 2, 2021
@RiddhiAthreya RiddhiAthreya linked a pull request Jul 6, 2021 that will close this issue
Open
11 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@RiddhiAthreya RiddhiAthreya

Labels
Category: Coding Changes to code base or refactored code that doesn't fix a bug. Type: Enhancement New feature or request.
Projects
None yet
Milestone
No milestone
5 participants
@isabelcosta @vermastuti @bartekpacia @RiddhiAthreya @vj-codes