Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DEV: Refactoring MS for BIT integration #667

Open
4 tasks
mtreacy002 opened this issue Jul 15, 2020 · 2 comments
Open
4 tasks

DEV: Refactoring MS for BIT integration #667

mtreacy002 opened this issue Jul 15, 2020 · 2 comments
Assignees
Labels
BIT This labels issues that need to be completed to help BIT

Comments

@mtreacy002
Copy link
Member

mtreacy002 commented Jul 15, 2020

Is your feature request related to a problem? Please describe.
To achieve the target of 2 REST APIs (MS and BIT APIs) with one database (bit_schema database), MS schema needs to be refactored to accommodate BIT.

Describe the solution you'd like

  • Refactor one of the UserModel field from organization to current_organization to remove ambiguity with Organization table reference used in BridgeInTech schema.
  • Refactor the use of Float to Numeric with precision "16,6" so to avoid precision mismatch from data store/retrieve from db.
  • modify .travis.yml to employ postgresql as db for testing on travis build
  • add pytest-cov dependency in requirements.txt

Describe alternatives you've considered
NA

Additional context
This is a cross-project issue between MS and BIT where improvement will be made gradually throughout GSoC 2020 period.

@mtreacy002
Copy link
Member Author

@anitab-org/mentorship-android-maintainers and @anitab-org/coding-team , this issue is a cross-project issue to prepare for BIT - MS integration.
Can you please add BIT label to this issue and assign it to me. I'll push a PR for this issue.

@vj-codes vj-codes added the BIT This labels issues that need to be completed to help BIT label Jul 15, 2020
@mtreacy002
Copy link
Member Author

Thanks @vj-codes 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
BIT This labels issues that need to be completed to help BIT
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants