Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: Create user journey for request deletion #1007

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

test: Create user journey for request deletion #1007

wants to merge 1 commit into from

Conversation

decon-harsh
Copy link
Member

Description

This patch creates a user journey test depicting the process of sending a new mentorship request by a mentee to a mentor. The mentee then deletes the request sent.

Fixes #911

Type of Change:

  • Code
  • Quality Assurance

Code/Quality Assurance Only

  • New feature (non-breaking change which adds functionality pre-approved by mentors)

How Has This Been Tested?

Screenshot from 2021-02-18 21-32-34

Checklist:

  • My PR follows the style guidelines of this project
  • I have performed a self-review of my own code or materials
  • I have commented on my code or provided relevant documentation, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation

Code/Quality Assurance Only

  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@codecov
Copy link

codecov bot commented Feb 18, 2021 •
edited
Loading

Codecov Report

Merging #1007 (8463aa5) into develop (1765e56) will increase coverage by 0.01%.
The diff coverage is 97.82%.

❗ Current head 8463aa5 differs from pull request most recent head 893fa5d. Consider uploading reports for the commit 893fa5d to get more accurate results
Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #1007      +/-   ##
===========================================
+ Coverage    96.16%   96.18%   +0.01%     
===========================================
  Files          100      101       +1     
  Lines         5429     5475      +46     
===========================================
+ Hits          5221     5266      +45     
- Misses         208      209       +1
Impacted Files Coverage Δ
tests/user_journey/test_request_deletion_path.py 97.82% <97.82%> (ø)

@devkapilbansal devkapilbansal added the Status: Needs Review PR needs an additional review or a maintainer's review. label Feb 18, 2021
devkapilbansal
devkapilbansal reviewed Feb 20, 2021
View reviewed changes
Copy link
Member

@devkapilbansal devkapilbansal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wondered if we can make a base file for user_journey and import it in other files instead of repeating it in other files

@epicadk
Copy link
Member

epicadk commented Apr 9, 2021

Sorry Unapprove, I meant changes requested.

@epicadk epicadk added Status: Changes Requested Changes are required to be done by the PR author. and removed Status: Needs Review PR needs an additional review or a maintainer's review. labels Apr 9, 2021
@vj-codes
Copy link
Member

vj-codes commented May 5, 2021

@decon-harsh any updates here?

@vj-codes
Copy link
Member

@decon-harsh ^ ?

@epicadk
Copy link
Member

epicadk commented May 18, 2021

@decon-harsh ^ ?

Hi I think you missed the update on zulip. As long as this isn't blocking please leave this pr open.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@isabelcosta isabelcosta Awaiting requested review from isabelcosta isabelcosta is a code owner

@epicadk epicadk Awaiting requested review from epicadk

@devkapilbansal devkapilbansal Awaiting requested review from devkapilbansal

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
Status: Changes Requested Changes are required to be done by the PR author.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Create a user journey test from sending a mentorship request and the user deletes the request.
4 participants
@decon-harsh @epicadk @vj-codes @devkapilbansal