Skip to content
This repository has been archived by the owner on May 5, 2020. It is now read-only.

Problem in size of boxes of MinesweeperGame #351

Closed
4 tasks
anubhavpulkit opened this issue Feb 27, 2020 · 4 comments
Closed
4 tasks

Problem in size of boxes of MinesweeperGame #351

anubhavpulkit opened this issue Feb 27, 2020 · 4 comments

Comments

@anubhavpulkit
Copy link
Contributor

anubhavpulkit commented Feb 27, 2020

Description

In Minesweeper game, we define boxSize = Double(size.width) * boxSizeRelativeToWidth this equetion is not fit for some screen size. Especially for screen size of iPhone X and above models boxSize is too large and create an annoying view.

Mocks

systers issue 222

Acceptance Criteria

Update [Required]

  • [Changes in boxSize formula]
  • [Changes in newBox.position]

Definition of Done

  • All of the required items are completed.
  • Approval by 1 mentor.

Estimation

[6] hours

@anubhavpulkit
Copy link
Contributor Author

@sunjunkie Please have a look, I think I solve this issue up to tomorrow. The equation which we are using for box size is only applicable up to the iPhone 8 plus devices.

@MANI14011998
Copy link

this issue comes under #264 @AnubhavSingh16

@anubhavpulkit
Copy link
Contributor Author

@sunjunkie @MANI14011998 Ok so can I do that part-out of them or close this issue because in this issue assets are not required.

@sunjunkie
Copy link
Contributor

See my comments in issue #264

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants