Skip to content
This repository has been archived by the owner on May 5, 2020. It is now read-only.

First letter of text in the storySequence is visible in X modes #364

Closed
2 of 3 tasks
anubhavpulkit opened this issue Mar 4, 2020 · 11 comments · Fixed by #377
Closed
2 of 3 tasks

First letter of text in the storySequence is visible in X modes #364

anubhavpulkit opened this issue Mar 4, 2020 · 11 comments · Fixed by #377

Comments

@anubhavpulkit
Copy link
Contributor

anubhavpulkit commented Mar 4, 2020

Description

First letter of story sequence is hidden by the notch in X and new models.

Mocks

systers issue sequence story

systers issue story sequence 3

Acceptance Criteria

Update [Required]

  • [add safe area constraints in story sequence]

Definition of Done

  • All of the required items are completed.
  • Approval by 1 mentor.

Estimation

[2] hours

@anubhavpulkit
Copy link
Contributor Author

@sunjunkie please have a look.

@sunjunkie
Copy link
Contributor

You can work on this.

@anubhavpulkit
Copy link
Contributor Author

Thank You @sunjunkie

@sunjunkie
Copy link
Contributor

@aviralx10 You can work on this.

@aviralx10
Copy link

Thank you @sunjunkie

@sunjunkie
Copy link
Contributor

sunjunkie commented Mar 9, 2020

@AnubhavSingh16 In the future, please work on one issue at a time. If you can't fix the issue within a reasonable amount of time, let me know or it will be assigned to someone else. I'll review your PR.
@aviralx10 Please select another issue to work on.

@anubhavpulkit
Copy link
Contributor Author

@AnubhavSingh16 In the future, please work on one issue at a time. If you can't fix the issue within a reasonable amount of time, let me know or it will be assigned to someone else. I'll review your PR.
@aviralx10 Please select another issue to work on.

Ok Sorry @sunjunkie

@anubhavpulkit
Copy link
Contributor Author

anubhavpulkit commented Mar 9, 2020

@Aviral190694 issue 345 is free if you want to work and sorry I saw now after sending my PR if you want to give any suggestion or you have any other way to solve this issue then, please discuss it is helpful sorry.

@anubhavpulkit
Copy link
Contributor Author

and you are welcome to send Pull Request for this issue Thank You @aviralx10 and sorry @sunjunkie this is my mistake.

@aviralx10
Copy link

@AnubhavSingh16 ,I just saw your pull request and i had figured out a solution by updating the margin (CG value) :/ ... no problem ..i'll now work on another issue.

@anubhavpulkit
Copy link
Contributor Author

Ok thank you @aviralx10

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants