Skip to content
This repository has been archived by the owner on Jan 26, 2021. It is now read-only.

Add task using Celery to send email verification for signing up #1029

Open
4 tasks
keshakaneria opened this issue Aug 24, 2020 · 18 comments · May be fixed by #1118 or #1168
Open
4 tasks

Add task using Celery to send email verification for signing up #1029

keshakaneria opened this issue Aug 24, 2020 · 18 comments · May be fixed by #1118 or #1168
Assignees
Labels
Category: Coding Changes to code base or refactored code that doesn't fix a bug. Open Source Hack Type: Enhancement New feature or request.

Comments

@keshakaneria
Copy link
Member

Description

In order to login into the system, I need to verify my email address to get logged in for the first time through the mailed link. Currently, the email is displayed in the console itself.

Acceptance Criteria

Update [Required]

  • Add tasks using Celery
  • Email should be sent to the email address instead of printing it in console.

Celery is an asynchronous task scheduler which helps to run different process in background which can be used here in order to create tasks for mailing system.

Definition of Done

  • All of the required items are completed.
  • Approval by 1 mentor.

Estimation

3 hours

@keshakaneria keshakaneria added Category: Coding Changes to code base or refactored code that doesn't fix a bug. Open Source Hack Type: Enhancement New feature or request. labels Aug 24, 2020
@harsh7in
Copy link

hey @keshakaneria, can I work on this issue?

@keshakaneria
Copy link
Member Author

Sure you can, once the OSH event gets started.

@shubhank-saxena
Copy link

@keshakaneria is this task up for grabs? I would like to work on this as I have experience with celery

@keshakaneria
Copy link
Member Author

@shubhank-saxena are you working on this issue?

@keshakaneria
Copy link
Member Author

@harsh-9in Do you want to work on this issue?

@shubhank-saxena
Copy link

@keshakaneria I did try it out. But there are some issues on booting up of the docker image (port engagement of postgres). If not in urgent mode, I would be able to do this in 2-3 days

@khushishikhu
Copy link
Member

@keshakaneria may i take this issue

@keshakaneria
Copy link
Member Author

@keshakaneria I did try it out. But there are some issues on booting up of the docker image (port engagement of postgres). If not in urgent mode, I would be able to do this in 2-3 days

You can ask your queries on Zulip channel if you are stuck anywhere. Feel free to ask there. It's already late so we have to move on with the next participant. :)

@sujal111
Copy link

sujal111 commented Sep 8, 2020

I am willing to work and solve this issue. Please assign me the same

@keshakaneria
Copy link
Member Author

I am willing to work and solve this issue. Please assign me the same

Already assigned! You are most welcomed to contribute to some other new issues you are interested in!

@khushishikhu
Copy link
Member

@keshakaneria do we need to verify the email when we are signing up. and then when we login for the very first time the verification mail should be sent to out mail inbox?

@keshakaneria
Copy link
Member Author

@keshakaneria do we need to verify the email when we are signing up. and then when we login for the very first time the verification mail should be sent to out mail inbox?

When the user signs up for the first time, the email id needs to be verified, currently we have the verification link getting printed in console only. We also need to send the email to their personal mail boxes to get the verification link. You can also do it with SMTP. Have a look at this issue.

@khushishikhu
Copy link
Member

@keshakaneria actually i am a bit confused. do i need to create a view.py file in vms/home or i need to make changes in view.py file of vms/registration as in that the email function is defined

@keshakaneria
Copy link
Member Author

@keshakaneria actually i am a bit confused. do i need to create a view.py file in vms/home or i need to make changes in view.py file of vms/registration as in that the email function is defined

You can have a look at how SMTP works and what changes are required to do that which can give our required output. As you can see one of our participant have uploaded a video in the issue, it sends the mail through SMTP itself.

@priyanshurohilla
Copy link

@keshakaneria If this issue is available for reassignment please assign it to me

@keshakaneria
Copy link
Member Author

@keshakaneria If this issue is available for reassignment please assign it to me

@khushishikhu is working on this issue. You can other issues where there is no assignee.

@khushishikhu khushishikhu linked a pull request Sep 14, 2020 that will close this issue
10 tasks
@harsh7in
Copy link

Hey @keshakaneria can I work on this issue??

@keshakaneria
Copy link
Member Author

Hey @keshakaneria can I work on this issue??

Sure go ahead

@harsh7in harsh7in linked a pull request Dec 14, 2020 that will close this issue
3 tasks
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Category: Coding Changes to code base or refactored code that doesn't fix a bug. Open Source Hack Type: Enhancement New feature or request.
Projects
None yet
6 participants