Skip to content
This repository has been archived by the owner on Jan 26, 2021. It is now read-only.

[Bug] Features for volunteer not visible for users having organisation other than the listed ones #1042

Open
3 tasks
Kajol-Kumari opened this issue Aug 28, 2020 · 13 comments · May be fixed by #1079
Open
3 tasks
Assignees
Labels
Category: Coding Changes to code base or refactored code that doesn't fix a bug. Open Source Hack

Comments

@Kajol-Kumari
Copy link

Kajol-Kumari commented Aug 28, 2020

Description

Currently, we have none of the volunteer features available if we signup with an organisation other than the listed ones.

Mocks

imageedit_2_9999273369

Acceptance Criteria

Update

  • Fix this bug so that all the normal users should be able to avail the volunteer features and privileges.

Definition of Done

  • All of the required items are completed.
  • Approval by 1 mentor.

Estimation

2 hours

@Kajol-Kumari Kajol-Kumari added Category: Coding Changes to code base or refactored code that doesn't fix a bug. Open Source Hack labels Aug 28, 2020
@decon-harsh
Copy link
Member

Hey I am new in this community and I am participating in OSH can I take this up?

@raksh543
Copy link

I am willing to work on this issue

@Kajol-Kumari
Copy link
Author

Hey @decon-harsh please go ahead with this issue 👍
@raksh543 as we need to follow FCFS so can't assign this to you. Feel free to take up any other issue.

@decon-harsh
Copy link
Member

decon-harsh commented Sep 1, 2020

Hey @Kajol-Kumari I think there are options for the above mentioned issue..

Screenshots

Screenshot from 2020-09-01 10-55-44

Screenshot from 2020-09-01 10-58-19

Screenshot from 2020-09-01 10-58-24

I am sorry If I misunderstood anything! First Timer here!

@Kajol-Kumari
Copy link
Author

Hey @decon-harsh let me check this on my local. 'coz last time I had ran this on my local, I was not able to view anything except logout.

@decon-harsh
Copy link
Member

Just a request can you check it asap, cause I won't be assigned on multiple issues at once.

@Kajol-Kumari
Copy link
Author

Kajol-Kumari commented Sep 1, 2020

Wierd! I am still not able to see these options on my local @gaurivn @keshakaneria can anyone of you please confirm If you are able to access these features when logged in as normal user on your local.

@decon-harsh I am Unassigning you for now so that you can take other issue. Please go ahead with another issue for now till we get it cleared.

@decon-harsh
Copy link
Member

decon-harsh commented Sep 1, 2020

Hey @Kajol-Kumari , During signup whenever I entered a non-unique organisation or left it blank then it showed an error screen .

Screenshot from 2020-09-02 02-49-56

And then if we try to login with that user it takes us to the screen mentioned in the issue.

Screenshot from 2020-09-02 02-50-15

I guess the term normal user means as a volunteer?

I think if only a User instance is made and it is not declared an admin or volunteer then this happens.

@keshakaneria
Copy link
Member

keshakaneria commented Sep 2, 2020

@Kajol-Kumari will check once locally and let you know

@Kajol-Kumari
Copy link
Author

Kajol-Kumari commented Sep 2, 2020

Hey @decon-harsh Thanks for pointing this. Yes, the normal user is a volunteer. This is a bug and this was the same thing I was encountering. I am modifying the issue description accordingly to make the goal of this issue more clear.

@Kajol-Kumari Kajol-Kumari changed the title [Feature] View and Edit profile for users [Bug] Features for volunteer not visible for users having organisation other than the listed ones Sep 2, 2020
@decon-harsh
Copy link
Member

I would love to work on this..

I solved this issue locally .. Actually the unlisted_organization does create instead of get_or_create.

I think this will solve.

Can you assign me this again?

@Kajol-Kumari
Copy link
Author

Hey @decon-harsh as you have opened the PR for the previous assigned issue, you can go ahead with this one :)

@decon-harsh decon-harsh linked a pull request Sep 2, 2020 that will close this issue
3 tasks
@decon-harsh
Copy link
Member

Kindly review this.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Category: Coding Changes to code base or refactored code that doesn't fix a bug. Open Source Hack
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants