Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Audio tracks missing from audio tab in local anime #1767

Open
7 tasks done
perokhe opened this issue Sep 2, 2024 · 4 comments · May be fixed by #1834
Open
7 tasks done

Audio tracks missing from audio tab in local anime #1767

perokhe opened this issue Sep 2, 2024 · 4 comments · May be fixed by #1834
Labels
Bug Something isn't working

Comments

@perokhe
Copy link
Contributor

perokhe commented Sep 2, 2024

Steps to reproduce

  1. Open an episode
  2. Go to audio tab

Expected behavior

It should list all audio tracks of said episode

Actual behavior

There's no audio track, only "None"

Crash logs

No response

Aniyomi version

0.16.4.3-7809

Android version

Android 10

Device

Samsung Note 9

Other details

There is audio playing, I just can't change the track because it doesn't show any.
In the subtitles tab all subtitle tracks are listed and it shows the correct one on the video, but it says "None" is selected.

Acknowledgements

  • I have searched the existing issues and this is a new ticket, NOT a duplicate or related to another open or closed issue.
  • I have written a short but informative title.
  • If this is an issue with an extension, I should be opening an issue in the extension's repository.
  • I have gone through the FAQ and troubleshooting guide.
  • I have updated the app to version 0.16.4.3.
  • I have updated all installed extensions.
  • I will fill out all of the requested information in this form.
@perokhe perokhe added the Bug Something isn't working label Sep 2, 2024
@abdallahmehiz
Copy link
Member

The tracks loading logic should he redone in my opinion, it's pretty jank, sometimes duplicating or missing some tracks in the ui.

@fakebhai
Copy link
Contributor

fakebhai commented Sep 2, 2024

The tracks loading logic should he redone in my opinion, it's pretty jank, sometimes duplicating or missing some tracks in the ui.

#1721 's comment may help if someone wanna work on it

@perokhe
Copy link
Contributor Author

perokhe commented Sep 2, 2024

Ok, found the problem. I was using "jp" for lang instead of "ja," which caused the function to throw an exception.
Also, it seems that it doesn't work well when the track has a two-letter code lang.
For example, given a track "Full (eng)", it will work with lang "en" and "eng", but with the track "Full (en)" neither work.

@perokhe
Copy link
Contributor Author

perokhe commented Sep 2, 2024

Also, I think it would be better not to use the app's language by default if no lang is set. Sometimes I change the videos' default track and now it chooses a different one. If people need it they can always add their language to lang.

@Secozzi Secozzi linked a pull request Nov 25, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants