Fix sorting on Space Table (#397)

Author: palexvs

app/controllers/pg_hero/home_controller.rb

@@ -84,14 +84,15 @@ def space
       if @space_stats_enabled
         space_growth = @database.space_growth(days: @days, relation_sizes: @relation_sizes)
         @growth_bytes_by_relation = Hash[ space_growth.map { |r| [[r[:schema], r[:relation]], r[:growth_bytes]] } ]
-        case params[:sort]
-        when "growth"
+        if params[:sort] == "growth"
           @relation_sizes.sort_by! { |r| s = @growth_bytes_by_relation[[r[:schema], r[:relation]]]; [s ? 0 : 1, -s.to_i, r[:schema], r[:relation]] }
-        when "name"
-          @relation_sizes.sort_by! { |r| r[:relation] || r[:table] }
         end
       end
 
+      if params[:sort] == "name"
+        @relation_sizes.sort_by! { |r| r[:relation] || r[:table] }
+      end
+
       across = params[:across].to_s.split(",")
       @unused_indexes = @database.unused_indexes(max_scans: 0, across: across)
       @unused_index_names = Set.new(@unused_indexes.map { |r| r[:index] })

app/views/pg_hero/home/space.html.erb

@@ -40,10 +40,10 @@
   <table class="table space-table">
     <thead>
       <tr>
-        <th><%= link_to "Relation", {sort: "name"} %></th>
-        <th style="width: 15%;"><%= link_to "Size", {} %></th>
+        <th><%= link_to (params[:tables] ? "Table" : "Relation"), {sort: "name", tables: params[:tables]} %></th>
+        <th style="width: 15%;"><%= link_to "Size", {tables: params[:tables]} %></th>
         <% if @space_stats_enabled %>
-          <th style="width: 15%;"><%= link_to "#{@days}d Growth", {sort: "growth"} %></th>
+          <th style="width: 15%;"><%= link_to "#{@days}d Growth", {sort: "growth", tables: params[:tables]} %></th>
         <% end %>
       </tr>
     </thead>