Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace/Remove Close reviewer and sync #17586

Open
BrayanDSO opened this issue Dec 10, 2024 · 0 comments
Open

Replace/Remove Close reviewer and sync #17586

BrayanDSO opened this issue Dec 10, 2024 · 0 comments

Comments

@BrayanDSO
Copy link
Member

BrayanDSO commented Dec 10, 2024

And tbh, idk why that is a command. Syncing when leaving the app is the most natural option, doesn't require a command, and can be done in the background. Also, the desktop version doesn't have something similar.

"But someone may want to use it". People may want to have a command to close and open the browser, or the note editor, or whatever, but obviously a command to every one of them isn't a good idea. A Sync command makes more sense than Close and sync

Originally posted by @BrayanDSO in #17585 (review)


Proposal: Remove Close reviewer and sync

Preferred alternative: Replace it with a Sync command.

@Arthur-Milchior is doing most of that in #17399, including a toolbar menu action. Adding a command after that should be easy

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant