Custom study menu should have Increase Today's new/review card limit

[Arthur-Milchior]

How to reproduce:

• Create a deck Parent::Child
• ensure there is no cards in Parent
• have new cards in Child
• long tap Parent
• tap custom study

Expected result:

• as in anki, there should be the options to increase today's new or review card limit

Actual result:

• this option is not present

[david-allison]

Why? The dialog will close with a no-op if there's no new/review cards available

[Arthur-Milchior]

Even if there are new cards we could show, the option to increase the number of new cards is not presented in ankidroid's custom study.
I understand I selected an absurd screenshot, with it's zero new cards. Sorry for that. Is it what caused your remark regarding the no-op?

[david-allison]

Yes, because we support the functionality but only display it when it's available

[Arthur-Milchior]

After more investigation, I just understood what's wrong here. It's broken when the new cards are present in subdeck only.
I didn't realize this was important and so omitted it from my reproduction steps.
I edited it.
Would you agree, now, that there is an issue to solve?

[Arthur-Milchior]

Okay, my bad. I realize that, at least on anki, the feature is enabled, it does not throw an error. However, it does not actually lead to more reviews. The cards in subdecks are ignored. I'll go ask anki whether that's the expected behavior. The manual is not clear about it, and, worse, the number of cards in subdeck is shown, so I'd assume it actually matters.

https://forums.ankiweb.net/t/custom-study-increase-new-card-number-and-subdeck/53634

[Arthur-Milchior]

Also, but this a details I find less important. I prefer when actions that are unavailable are disabled rather than removed. Or even enable the radio button and disable the "ok" button.

Here is the scenario that confused me:
I was done with my current deck. I wanted to add more cards. So I used custom study. And here I thought "that's strange, why do I not see the option to add more cards. I was sure it was there. I must have mixed it with another menu. Or maybe it was moved recently". I would have appreciated something telling me that there is no more new cards and that I'll only have reviews from now on.