Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

digestif virtual library compat #59

Closed
joprice opened this issue Aug 16, 2023 · 1 comment · Fixed by #67
Closed

digestif virtual library compat #59

joprice opened this issue Aug 16, 2023 · 1 comment · Fixed by #67

Comments

@joprice
Copy link

joprice commented Aug 16, 2023

I ran into an issue when using this library alongside another that chose the digestif.c as the implementation for digestif. Should all libraries avoid selecting the concrete implementation, leaving it up to the consumer, or is there a reason that the ocaml one is required for this lib? https://github.com/anmonteiro/websocketaf/blob/aa6a1472926ac496b3403a0dafb0360a1bb32623/eio/dune#L4
@anmonteiro
Copy link
Owner

absolutely. fixing this in #67

@anmonteiro anmonteiro mentioned this issue Aug 1, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

don't select digestif implementation anmonteiro/httpun-ws
2 participants
@anmonteiro @joprice