Skip to content
This repository has been archived by the owner on Jun 4, 2022. It is now read-only.

Search history with buffer on pressing arrow key #62

Closed
tiye opened this issue Jan 4, 2017 · 7 comments
Closed

Search history with buffer on pressing arrow key #62

tiye opened this issue Jan 4, 2017 · 7 comments

Comments

@tiye
Copy link
Contributor

tiye commented Jan 4, 2017

It's a feature in Boot REPL. I don't know what to call it but I use it for long. For example I got some histories:

(+ 1 2)
(+ 2 3)
(- 2 1)
(- 3 2)

Now I typed (+ in the REPL and use Up key to find history. Currently I got any history one by one. But in Boot, only (+ 1 2) (+ 2 3) are matched since the beginner characters are the same.

I'm considering it as a new feature we need.

@arichiardi
Copy link
Collaborator

Wow neat, you made me discover this feature in boot repl 😁

@tiye
Copy link
Contributor Author

tiye commented Jan 5, 2017

@arichiardi I'm using this features for years in Bash:

=>> cat ~/.inputrc
"\e[A":history-search-backward
"\e[B":history-search-forward

set show-all-if-ambiguous on
set completion-ignore-case on

@anmonteiro
Copy link
Owner

If we're going to do something similar, I would probably prefer implementing something like Planck's new reverse i-search feature.

@jiyinyiyong Thoughts?

@tiye
Copy link
Contributor Author

tiye commented Feb 23, 2017

Well, I think history-search-backward is easier to implement since we only need to test with start-with?. reverse i-search would be fine. But I have to say personally I never used Ctrl R in real my work.

@didibus
Copy link

didibus commented Apr 23, 2017

I think I prefer reverse-i-search since it's more standart across shells, more people will know about it instinctively. It's also more powerful.

I can also find the up behavior a bit intrusive. Reber i search is more optional.

@anmonteiro
Copy link
Owner

anmonteiro commented Jun 1, 2017

Working PR in #169

@anmonteiro
Copy link
Owner

fixed 8486b14

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants