feat: fixing ibc shielded gas estimate #1567
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pedrorezende
requested review from
euharrison,
mateuszjasiuk and
jurevans
and removed request for
euharrison
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First version of estimate gas calculation for IBC shielded transfers. Still requires some minor improvements / tweaks that I'll leave for later PRs, like loading state or refresh button.
I also added 5% more over the estimated gas just to make sure that the transaction will succeed. Maybe we can tweak this percentage using the gas usage selection modal /cc @euharrison
Closes #1486