Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

eos_route_maps module does not have check mode #481

Open
jakegroves opened this issue Nov 8, 2023 · 1 comment · May be fixed by #480
Open

eos_route_maps module does not have check mode #481

jakegroves opened this issue Nov 8, 2023 · 1 comment · May be fixed by #480
Labels
has_pr This issue has an associated PR.

Comments

@jakegroves
Copy link

SUMMARY

When using the "eos_route_maps" module it does not have the functionality to run --check, so cannot add in steps to do any sanity-checking

ISSUE TYPE
  • Bug Report
COMPONENT NAME

eos_route_maps

ANSIBLE VERSION
ansible [core 2.14.1]
  config file = /Users/user/git/ansible-arista/ansible.cfg
  configured module search path = ['/Users/user/git/ansible-arista/plugins']
  ansible python module location = /Users/user/.pyenv/versions/3.11.1/lib/python3.11/site-packages/ansible
  ansible collection location = /Users/user/.ansible/collections:/usr/share/ansible/collections
  executable location = /Users/user/.pyenv/versions/3.11.1/bin/ansible
  python version = 3.11.1 (main, Jan 27 2023, 00:37:35) [Clang 14.0.0 (clang-1400.0.29.202)] (/Users/user/.pyenv/versions/3.11.1/bin/python3.11)
  jinja version = 3.1.2
  libyaml = True
COLLECTION VERSION
# /Users/user/.ansible/collections/ansible_collections
Collection Version
---------- -------
arista.eos 6.2.1
CONFIGURATION
CONFIG_FILE() = /Users/user/git/ansible-arista/ansible.cfg
DEFAULT_HOST_LIST(/Users/user/git/ansible-arista/ansible.cfg) = ['/Users/user/git/ansible-arista/inventory']
DEFAULT_LOG_PATH(/Users/user/git/ansible-arista/ansible.cfg) = /Users/user/git/ansible-arista/ansible.log
DEFAULT_MODULE_PATH(env: ANSIBLE_LIBRARY) = ['/Users/user/git/ansible-arista/plugins']
DEFAULT_NO_LOG(/Users/user/git/ansible-arista/ansible.cfg) = False
DEFAULT_STDOUT_CALLBACK(env: ANSIBLE_STDOUT_CALLBACK) = default
DEFAULT_TIMEOUT(/Users/user/git/ansible-arista/ansible.cfg) = 5
HOST_KEY_CHECKING(/Users/user/git/ansible-arista/ansible.cfg) = False
INTERPRETER_PYTHON(/Users/user/git/ansible-arista/ansible.cfg) = /usr/bin/env python3
OS / ENVIRONMENT

destination device is running EOS 4.28.8M

STEPS TO REPRODUCE

Example playbook

- name: Replace provided route map configuration
  arista.eos.eos_route_maps:
    state: replaced
    config: "{{ eos_route_maps.config }}"
  register: replace_route_map_command

- name: Display route map changes
  debug:
    var: replace_route_map_command.commands
  when: replace_route_map_command is changed

output below

PLAY [router] ***************************************************************************************************************************************************************************************************************************************

TASK [route_map : Replace provided route map configuration] *****************************************************************************************************************************************************************************************
skipping: [router1]

TASK [route_map : Display route map changes] ********************************************************************************************************************************************************************************************************
skipping: [router1]
EXPECTED RESULTS

arista.eos.eos_route_map to not skip, so can register output and display
On a separate branch (PR): #480
I expect to get the following like I do so with the eos_prefix_lists behaviour:

PLAY [router] ***************************************************************************************************************************************************************************************************************************************

TASK [route_map : Replace provided route map configuration] *****************************************************************************************************************************************************************************************
changed: [router1]

TASK [route_map : Display route map changes] ********************************************************************************************************************************************************************************************************
ok: [router1] => {
    "replace_route_map_command.commands": [
        "route-map Example-RM permit 10",
        "set local-preference 110"
    ]
}
ACTUAL RESULTS
PLAY [router] ***************************************************************************************************************************************************************************************************************************************

TASK [route_map : Replace provided route map configuration] *****************************************************************************************************************************************************************************************
skipping: [router1]

TASK [route_map : Display route map changes] ********************************************************************************************************************************************************************************************************
skipping: [router1]
@jakegroves
Copy link
Author

PR: #480

@jakegroves jakegroves linked a pull request Nov 8, 2023 that will close this issue
Open
@NilashishC NilashishC added the has_pr This issue has an associated PR. label Nov 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
has_pr This issue has an associated PR.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add in check_mode to be supported for eos_route_maps jakegroves/arista.eos
3 participants
@NilashishC @jakegroves @rohitthakur2590