Fix 496 - remove string substitution #502
Conversation
for more information, see https://pre-commit.ci
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #502 +/- ##
==========================================
+ Coverage 82.76% 82.87% +0.11%
==========================================
Files 153 153
Lines 11967 11966 -1
==========================================
+ Hits 9904 9917 +13
+ Misses 2063 2049 -14 ☔ View full report in Codecov by Sentry. |
|
The ACL tests for IPv6 fail: The device IPv6 commands will be parsed as dictionary keys with an underscore. Therefore my fix isn't working. Back to the drawing board... |
rohitthakur2590
had a problem deploying
to
ack
GitHub Actions
Failure
|
Label error. Requires exactly 1 of: bug, enhancement, major, minor, patch, skip-changelog. Found: |
|
@rohitthakur2590 I don't think that it's possible or even good to merge my PR as there are several open issues with the I would like to add a new parent issue to collect all issues for that module (...there are also issues that have no issue report, yet...). From there on we can discuss how to proceed. Do you also think that that would be a good way to go? |
|
@TheRealBecks I agree! Let's open one separate issue for ACLS and mention all the acls specifics issues in that for the sake of better tracking. |
Fixes #496
SUMMARY
-have been wrongly replaced by_inport_protocolcausing dictionary key comparisons.ISSUE TYPE
COMPONENT NAME
eos_acls