-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Vendor/bundle dependency hcloud-python #218
Comments
I am not sure if I understand this correctly but I would not bundle it but test for the hcloud-python version in the code. This is what other collections do as well. |
Hi @resmo, Also, could you paste the links to the collections that choose to check the library version ?
and those who choose to follow the vendoring path: |
In community.docker (stable-2 branch, before we vendored some parts of Docker SDK for Python - now we only have checks left for the API version) we were checking both the API version and the Docker SDK for Python version per feature. In the case of the docker_container module, it looks like: https://github.com/ansible-collections/community.docker/blob/stable-2/plugins/modules/docker_container.py#L3482-L3507 So for example if the user supplies the Obviously this requires some bookkeeping, and making sure that the module code doesn't try to use a feature that isn't there. That way the module was supporting a large range of Docker daemon API versions and Docker SDK for Python versions. (For the current |
SUMMARY
We should include the hcloud-python code in the release assets for the ansible collection.
Adding a new feature in our API to the ansible collection, usually also requires a new matching release of hcloud-python. This has caused multiple issues in the past where people did not update hcloud-python together with the ansible collection, which broke their setup (#209, #210).
In one of the latest versions, I added the requirement to update hcloud-python as a breaking change to the release notes, which (rightfully) summoned #217.
By bundling hcloud-python with the collection, we can avoid all these issues.
ISSUE TYPE
COMPONENT NAME
ADDITIONAL INFORMATION
Replaces #211
Fixes #217
The text was updated successfully, but these errors were encountered: