Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: ansible/ansible-lint
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: v6.6.1
Choose a base ref
...
head repository: ansible/ansible-lint
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: v6.7.0
Choose a head ref
  • 10 commits
  • 39 files changed
  • 7 contributors

Commits on Sep 21, 2022

  1. Use site.getuserbase() to detect ansible executable (#2477)

    As it is quite common for many users to miss adding python bin scripts
    folder to their PATH, even if pip does warn them about the issue, we
    now add it dynamically.
    
    Fixes: #2357
    ssbarnea authored Sep 21, 2022

    Verified

    This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
    Copy the full SHA
    455a909 View commit details
  2. Verified

    This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
    Copy the full SHA
    e00891b View commit details
  3. Ensure that symlink-arguments are resolved (#2476)

    - Fixes bug where a giving a symlinked directory as argument would
      fail to lint the entire role, basically because the linter failed
      to resolve the link before processing all lintables within it.
    - Ensure we resolve symlink in Lintable constructor
    - Add normalization function that returns a Path
    ssbarnea authored Sep 21, 2022

    Verified

    This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
    Copy the full SHA
    fd2ecfe View commit details

Commits on Sep 22, 2022

  1. Verified

    This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
    Copy the full SHA
    2482270 View commit details
  2. Change rich markdown theme/colors (#2486)

    * Change rich markdown theme/colors
    
    * chore: auto fixes from pre-commit.com hooks
    
    for more information, see https://pre-commit.ci
    
    Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
    ssbarnea and pre-commit-ci[bot] authored Sep 22, 2022

    Verified

    This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
    Copy the full SHA
    55068d7 View commit details

Commits on Sep 23, 2022

  1. fix: use ansible-compat to install collections (#2466)

    * fix: use ansible-compat to install collections
    
    * chore: clean-up pylint failures
    
    * test: drop mocking tests
    
    These tests are no longer useful since they are checking for a behaviour
    that is no longer present in the code, but handled by `ansible-compat`.
    
    * fix: move example galaxy.yml file for tests
    
    The example galaxy.yml is invalid since it points to non-existant
    collections, this breaks some of the other tests which try and build
    a runtime and try and install it.
    
    * fix: drop PYTEST_REQPASS
    
    * Bump compat
    
    Co-authored-by: Sorin Sbarnea <ssbarnea@redhat.com>
    Co-authored-by: Sorin Sbarnea <sorin.sbarnea@gmail.com>
    3 people authored Sep 23, 2022

    Verified

    This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
    Copy the full SHA
    e248b64 View commit details
  2. name[template]: recommend to use templating as suffix on names (#2483)

    * add named templated
    
    * added named template play book
    
    * chore: auto fixes from pre-commit.com hooks
    
    for more information, see https://pre-commit.ci
    
    * Fixed code
    
    Co-authored-by: vineethreddykaturu <vkaturu@redhat.com>
    Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
    Co-authored-by: Sorin Sbarnea <ssbarnea@redhat.com>
    Co-authored-by: Sorin Sbarnea <sorin.sbarnea@gmail.com>
    5 people authored Sep 23, 2022

    Verified

    This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
    Copy the full SHA
    7258dba View commit details
  3. Ensure we do not return relative paths outside the project (#2492)

    Makes normpath match normpath_path one and avoid returning relative
    paths outside current working directory / project.
    
    This should fix the WSL job, which was running the testing outside
    user home directory, and that produced different file paths.
    ssbarnea authored Sep 23, 2022

    Verified

    This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
    Copy the full SHA
    31a1092 View commit details
  4. Extend key-order key to sort more keys than the name (#2454)

    - refactor key ordering to allow us to sort all keys
    - ensure `block`/`rescue`/`always` are sorted `last`
    ssbarnea authored Sep 23, 2022

    Verified

    This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
    Copy the full SHA
    01d2e6d View commit details
  5. Refactor no-loop-var-prefix rule (#2470)

    * docs lint rule no-loop-var
    
    * chore: auto fixes from pre-commit.com hooks
    
    for more information, see https://pre-commit.ci
    
    * Refactor no-loop-var-prefix
    
    - rename rule to loop-var-prefix and keep alias for old name
    - make rule produce more detailed messages
    - add documentation to the rule
    
    Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
    Co-authored-by: Sorin Sbarnea <sorin.sbarnea@gmail.com>
    3 people authored Sep 23, 2022

    Verified

    This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
    Copy the full SHA
    e4de1cd View commit details
Loading