Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve ctrl-c exit #1435

Merged
merged 1 commit into from
Mar 6, 2021
Merged

Improve ctrl-c exit #1435

merged 1 commit into from
Mar 6, 2021

Conversation

ssbarnea
Copy link
Member

@ssbarnea ssbarnea commented Mar 6, 2021

Avoid displaying stack-tracke on Ctrl-C and return standard exit code 130 for this case.

aminvakil
aminvakil reviewed Mar 6, 2021
View reviewed changes
Copy link
Contributor

@aminvakil aminvakil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Typo?

src/ansiblelint/__main__.py Outdated Show resolved Hide resolved
src/ansiblelint/__main__.py Outdated Show resolved Hide resolved
src/ansiblelint/constants.py Outdated Show resolved Hide resolved
@ssbarnea
Improve ctrl-c exit
d253da5 
Avoid displaying stack-tracke on Ctrl-C and return standard exit
code 130 for this case.
aminvakil
aminvakil approved these changes Mar 6, 2021
View reviewed changes
Copy link
Contributor

@aminvakil aminvakil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Definitely more readable this way.

@ssbarnea ssbarnea merged commit 9ddd2c3 into master Mar 6, 2021
@ssbarnea ssbarnea deleted the 0/labels branch March 6, 2021 09:55
This was referenced Mar 11, 2021
Closed
Merged
Closed
Merged
Merged
Open
Merged
Closed
Closed
Closed
Closed
Merged
Closed
Closed
Closed
Merged
Merged
Merged
Merged
Closed
Closed
@dependabot dependabot bot mentioned this pull request Mar 18, 2021
Merged
This was referenced Mar 18, 2021
Merged
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aminvakil aminvakil aminvakil approved these changes

Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ssbarnea @aminvakil