Move source subdir #24
Conversation
abadger
force-pushed
the
move-source-subdir
branch
2 times, most recently
from
43e7d3b
to
c5d89cb
Compare
|
I think we're stuck for now with this: python-poetry/poetry#1811 I might be able to work around it by moving the test directory into src/ as well but I'd like to hold off and see if poetry fixes that first. The poetry bug breaks |
|
Our case is slightly different from the one reported before. I opened a second bug here: python-poetry/poetry#2450 I think that with the current code, a fix for either one of the two bugs will fix our usage. |
|
I see there is a WIP PR at python-poetry/poetry-core#108 wonder if that helps |
abadger
force-pushed
the
move-source-subdir
branch
3 times, most recently
from
63af5e1
to
66d8f3f
Compare
|
Hey @felixfontein , I don't know if you still want this; the slowdown only happens if pyre (or another tool) ends up scanning directories of python code that might get created in the toplevel (When I first noticed it, I had an ansible_collection directory somewhere in my source tree because I ran antsibull-build with the checkout as the destination or something). I just completed this since upstream for poetry said they had fixed the bug and I wanted to test that for them. (If you don't want to move the source dir, you may still want to cherry-pick the first commit here. That moves from using poetry to poetry-core for the build-system in pyproject.toml. Doing that should mean that pip install antsibull won't have to install all of poetry and its dependencies anymore) |
poetry has been split into poetry and poetry-core. The core is a small subset of functionality that is what is necessary to build python packages. Changing from poetry to poetry-core should improve the `pip install antsibull` experience since all of poetry and its dependencis won't be needed. The update to a newer version is also needed to solve: > python-poetry/poetry#2450 and allow us to put the source in a subdirectory
pyre prefers to be given the directory which holds your python package as the source-directory rather than the directory which is your python package. However, if the directory given is the toplevel, pyre tends to get slow for me. (I believe since it scans temporary directories that I have accumulated [downloads of all those ansible collections...]). Putting the source code in its own subdirectory is the way to fix that.
felixfontein
force-pushed
the
move-source-subdir
branch
from
66d8f3f
to
2a933e1
Compare
|
@abadger thanks a lot for finishing this PR! I'll definitely merge this :) (just merged something else first and then rebased) |
|
Thanks felix!
…On Mon, Nov 15, 2021, 11:28 AM Felix Fontein ***@***.***> wrote:
Merged #24 <#24> into
main.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#24 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AABTCWUZH5JPMHAF57X4NT3UMFNPTANCNFSM4NGTGWCA>
.
Triage notifications on the go with GitHub Mobile for iOS
<https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675>
or Android
<https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.
|
Move source of ansibulled to a subdir.
pyre prefers to be given the directory which holds your python package
as the source-directory rather than the directory which is your python
package. However, if the directory given is the toplevel, pyre tends to
get slow for me. (I believe since it scans temporary directories that
I have accumulated [downloads of all those ansible collections...]).
Putting the soure code in its own subdirectory is the way to fix that.