-
Notifications
You must be signed in to change notification settings - Fork 503
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Unable to build documentation in proxy-only network environments using nox #1936
Comments
@felixfontein FYI, this one might be of interest to you as there are |
antsibull-core and antsibull-docs use aiohttp (https://pypi.org/project/aiohttp/) for network requests. It seems to be possible to configure proxy usage there: https://docs.aiohttp.org/en/stable/client_advanced.html#proxy-support I'm not sure if there's support for environment variables like the ones mentioned above, I guess not (otherwise it should have worked I guess). |
It seems to be supported |
Edit: we could also make this configurable (with default |
Yeah, I think it makes sense to have that as the default.
Unless there's a strong reason to add a config that I'm missing, I'd prefer to just keep this simple. |
Coming from the Systems side of things, I'd expect applications to implicitly respect my proxy settings. So, defaulting to |
antsibull-docs 2.15.0 now supports env variables for proxy configuration. #1994 updates the dependencies for this repo to use this version. |
I have checked out the new code and can verify that the fix works, thanks! |
Great to hear! :) |
I am in a network environment where internet access is only possible via a forward proxy service, and I noticed that the documentation build will error in the following occasions including but not limited to:
Session checkers(docs-build):
../../hacking/build-ansible.py docs-build core -o rst:
I have set and exported the following proxy-related environment variables:
$ printenv | grep -i proxy no_proxy=localhost https_proxy=http://192.168.49.1:8228 NO_PROXY=localhost HTTPS_PROXY=http://192.168.49.1:8228 HTTP_PROXY=http://192.168.49.1:8228 http_proxy=http://192.168.49.1:8228
and have the Docker daemon configured to use the proxy service:
It would be great if these settings are fully honored so that the build can be completed without switching network environments. Thanks in advance!
The text was updated successfully, but these errors were encountered: