commit 7fa5f76e0333a97476b5204487f183efb5e3d467 breaks backward compatibility of the ansible-lint github action

[zerwes]

Summary

while 2 days ago calling ansible/ansible-lint@v6.22.0 (see https://github.com/zerwes/ansible-role-checkmkagent/actions/runs/7083656545) worked without any problems, after the commit 7fa5f76 calling a tagget version of the action will fail due to the file renaming with a error (see https://github.com/Rosa-Luxemburgstiftung-Berlin/ansible-opnsense/actions/runs/7097243220/job/19317040697)

error:

Run wget --output-document=.git/ansible-lint-requirements.txt https://raw.githubusercontent.com/ansible/ansible-lint/main/.config/requirements-lock.txt
--2023-12-05 06:56:03--  https://raw.githubusercontent.com/ansible/ansible-lint/main/.config/requirements-lock.txt
Resolving raw.githubusercontent.com (raw.githubusercontent.com)... 1[8](https://github.com/Rosa-Luxemburgstiftung-Berlin/ansible-opnsense/actions/runs/7097243220/job/19317040697#step:3:10)5.1[9](https://github.com/Rosa-Luxemburgstiftung-Berlin/ansible-opnsense/actions/runs/7097243220/job/19317040697#step:3:11)9.111.133, 185.199.108.133, 185.199.109.133, ...
Connecting to raw.githubusercontent.com (raw.githubusercontent.com)|185.199.111.133|:443... connected.
HTTP request sent, awaiting response... 404 Not Found
2023-12-05 06:56:03 ERROR 404: Not Found.

Issue Type

• Bug Report

OS / ENVIRONMENT

github action

STEPS TO REPRODUCE

create a github action with

jobs:
  build:
    name: ansible lint
    runs-on: ubuntu-latest
    steps:
      - uses: actions/checkout@v4
      - name: run ansible-lint
        uses: ansible/ansible-lint@v6.22.0

Desired Behavior

agile paradigm should not break backward compatibility ...

Actual Behavior

see https://github.com/Rosa-Luxemburgstiftung-Berlin/ansible-opnsense/actions/runs/7097243220/job/19317040697

[TehreemNisa]

This is happening for us as well , is their a workaround available?

[KhizerJaan]

Facing same issue . any solution would be highly appreciated

[zerwes]

my interim fix is to use the latest aka. main instead of a pinned version/tag
see Rosa-Luxemburgstiftung-Berlin/ansible-opnsense@23b36c9

[McSim85]

it's weird if I use the specific version: v6.20.0

name: ansible-lint
on: [pull_request]

jobs:
  build:
    name: Ansible Lint # Naming the build is important to use it as a status check
    runs-on: ubuntu-latest
    steps:
      - name: Checkout Code
        uses: actions/checkout@v2
      - name: Run ansible-lint
        uses: ansible/ansible-lint@v6.20.0

GitHub actions still wgets the main branch.

Run wget --output-file=.git/ansible-lint-requirements.txt https://raw.githubusercontent.com/ansible/ansible-lint/main/.config/requirements-lock.txt
  wget --output-file=.git/ansible-lint-requirements.txt https://raw.githubusercontent.com/ansible/ansible-lint/main/.config/requirements-lock.txt
  shell: /usr/bin/bash --noprofile --norc -e -o pipefail {0}
Error: Process completed with exit code 8.

Shouldn't it be v6.20.0 branch?
https://raw.githubusercontent.com/ansible/ansible-lint/v6.20.0/.config/requirements-lock.txt
?

[McSim85]

I think this was the fix
#3762

[McSim85]

So, anything before 6.22.1 is broken
d7c9bff

[audgirka]

Fixed as part of #3929

[zerwes]

can confirm the fix is working ... at least the workflow will not fail due to the missing requirement file ...
but now it will run against main, independent of the tag / version you configured

Run ansible/ansible-lint@v6.22.0
  with:
    setup_python: true
Run wget --output-document=.git/ansible-lint-requirements.txt https://raw.githubusercontent.com/ansible/ansible-lint/main/.config/requirements-lock.txt
...
Building wheels for collected packages: ansible-lint
175
  Building wheel for ansible-lint (pyproject.toml): started
176
  Building wheel for ansible-lint (pyproject.toml): finished with status 'done'
177
  Created wheel for ansible-lint: filename=ansible_lint-6.22.2.dev8-py3-none-any.whl size=297703 
...
ansible-lint 6.22.2.dev8 using ansible-core:2.16.0 ansible-compat:4.1.10 ruamel-yaml:0.18.5 ruamel-yaml-clib:0.2.8
You are using a pre-release version of ansible-lint.
Run ansible-lint
...

https://github.com/Rosa-Luxemburgstiftung-Berlin/ansible-opnsense/actions/runs/7114305453/job/19368083185

[McSim85]

@zerwes this should be fixed in

#3762

So, any versions after 6.22.1 should use versioned branch

[zerwes]

So, any versions after 6.22.1 should use versioned branch

good to hear ... the future is saved ... 👍
... but what about backward compatibility? "any versions after 6.22.1" means for now: no released version :-(
I think #3933 fixes the eval of the var, so it will not fallback to main