Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

AAP-15464: Enable Opt-Out Telemetry (the UI/UX to enable). Parameterise timeout #751

Merged
merged 1 commit into from
Dec 11, 2023
Merged

AAP-15464: Enable Opt-Out Telemetry (the UI/UX to enable). Parameterise timeout #751

merged 1 commit into from
Dec 11, 2023

Conversation

manstis
Copy link
Contributor

@manstis manstis commented Dec 11, 2023

Further to #718

Description

This PR parameterizes the /me endpoint cache timeout to facilitate tests.

Testing

  1. Pull down the PR
  2. make start-backends
  3. make create-application
  4. Start the wisdom-service (varies per developer)

Scenarios tested

The /me endpoint should work.

Changes to the Telemetry optOut flag should be reflected according to the configured cache timeout.

Production deployment

  • This code change is ready for production on its own
  • This code change requires the following considerations before going to production:

tomershinhar
tomershinhar approved these changes Dec 11, 2023
View reviewed changes
Copy link
Contributor

@tomershinhar tomershinhar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@manstis manstis merged commit 36ca1d3 into main Dec 11, 2023
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tomershinhar tomershinhar tomershinhar approved these changes

@robinbobbitt robinbobbitt Awaiting requested review from robinbobbitt

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@manstis @tomershinhar