Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

win_reboot: Default reboot_timeout (600 sec) may not suffice #47229

Closed
dagwieers opened this issue Oct 17, 2018 · 7 comments
Closed

win_reboot: Default reboot_timeout (600 sec) may not suffice #47229

dagwieers opened this issue Oct 17, 2018 · 7 comments
Assignees
Labels
affects_2.8 This issue/PR affects Ansible v2.8 bug This issue/PR relates to a bug. module This issue/PR relates to a module. support:core This issue/PR relates to code supported by the Ansible Engineering Team. windows Windows community

Comments

@dagwieers
Copy link
Contributor

SUMMARY

Currently the win_reboot module comes with a pre-configured default value of 600 seconds for the reboot_timeout. For normal reboot this may suffice, but a few conditions could result in unexpected failures.

  • The system may have updates applied before rebooting, which results in additional pre-boot and post-boot processing, and occasionally additional reboots.

  • The system may have been configured with a delayed startup of the WinRM service, a necessary mitigation for issues related to WinRM being available before the system was fully settled (causing unexpected behavior, e.g. AD operations failing).

  • Physical systems may take a longer time to shut down and reboot.

Currently there is no straight-forward way for Ansible to check if updates have been applied and take these into account when rebooting. So it is probably best for the user to increase the reboot_timeout to something higher than the highest value you may encounter, like reboot_timeout: 3600.

This ticket exists to discuss possible workarounds or improvements to the general issue.

ISSUE TYPE
  • Bug Report
COMPONENT NAME

win_reboot

ANSIBLE VERSION

Possibly every version

@dagwieers dagwieers added the windows Windows community label Oct 17, 2018
@ansibot

This comment has been minimized.

@ansibot

This comment has been minimized.

@ansibot
Copy link
Contributor

ansibot commented Oct 17, 2018

@ansibot ansibot added affects_2.8 This issue/PR affects Ansible v2.8 bug This issue/PR relates to a bug. module This issue/PR relates to a module. support:core This issue/PR relates to code supported by the Ansible Engineering Team. labels Oct 17, 2018
@dagwieers
Copy link
Contributor Author

The problem translates to the win_updates module as well, when reboot: yes is used and updates may take longer than the default 1200 seconds (20 minutes) reboot_timeout setting.

@ansibot
Copy link
Contributor

ansibot commented Feb 17, 2019

cc @if-meaton
click here for bot help

@ShachafGoldstein
Copy link
Contributor

Seems like this script that checks for reboot pending machine could help in some cases
https://gallery.technet.microsoft.com/scriptcenter/Windows-Updates-and-684c355c

@jborean93
Copy link
Contributor

It's hard to come up with a sane default, for the most count the defaults we have today seem to be fine on most servers there are just exceptions to this. This can be due to so many different factors where if we were to increase it to 1200 seconds today it still might not be enough for some people. In any case win_updates with reboot: yes actually has a default timeout of 1200 seconds to account for the load that installing updates might add to the system.

In any case if this is not enough for a user they have ways of increasing this time for their particular server.

@ansible ansible locked and limited conversation to collaborators Mar 3, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
affects_2.8 This issue/PR affects Ansible v2.8 bug This issue/PR relates to a bug. module This issue/PR relates to a module. support:core This issue/PR relates to code supported by the Ansible Engineering Team. windows Windows community
Projects
None yet
Development

No branches or pull requests

5 participants