Windows setup module inconsistent with Linux setup module and custom fact_path

[StephenGevers]

SUMMARY

We have set up a local facts directory at an alternate location on some of our machines because we do not have root access and cannot create the /etc/facts.d directory. We added the configuration fact_path= in the ansible.cfg file such that it points to the Linux location where we can create our custom facts. On Linux hosts that where the directory doesn't exist, everything works fine. On Windows hosts, the gather facts task fails with "The path does not exist. Typo?"

Note:
setup.ps1 has:

if (-not (Test-Path -Path $factpath)) {
    Fail-Json $result "The path $factpath does not exist. Typo?"
  }

local.py (module_utils/facts/system/local.py) has

        if not fact_path or not os.path.exists(fact_path):
            return local_facts

ISSUE TYPE

• Bug Report

COMPONENT NAME

lib/modules/windows/setup.ps1

ANSIBLE VERSION

ansible 2.7.10
  config file = /opt/app/workload/ansible/ansible.cfg
  configured module search path = [u'/opt/app/workload/ansible_core/ansible/modules', u'/opt/app/workload/ansible/ansible_cust/modules']
  ansible python module location = /opt/app/workload/ansible_core/ansible
  executable location = /opt/app/workload/ansible_core/bin/ansible
  python version = 2.7.15 (default, May  3 2019, 15:19:10) [GCC 4.4.7 20120313 (Red Hat 4.4.7-23)]

CONFIGURATION

[sg3235@zldv6099 plays]$ ansible-config dump --only-changed
CACHE_PLUGIN(/opt/app/workload/ansible/ansible.cfg) = memory
DEFAULT_ACTION_PLUGIN_PATH(/opt/app/workload/ansible/ansible.cfg) = [u'/opt/app/workload/ansible/ansible_cust/plugins/action', u'/opt/app/workload/ansible_cor
DEFAULT_CALLBACK_PLUGIN_PATH(/opt/app/workload/ansible/ansible.cfg) = [u'/opt/app/workload/ansible/ansible_cust/plugins/callback', u'/opt/app/workload/ansible
DEFAULT_CALLBACK_WHITELIST(/opt/app/workload/ansible/ansible.cfg) = [u'q_callback:service_callback']
DEFAULT_FACT_PATH(/opt/app/workload/ansible/ansible.cfg) = /opt/app/workload/tspace/facts
DEFAULT_FORKS(/opt/app/workload/ansible/ansible.cfg) = 50
DEFAULT_GATHER_TIMEOUT(/opt/app/workload/ansible/ansible.cfg) = 20
DEFAULT_HASH_BEHAVIOUR(/opt/app/workload/ansible/ansible.cfg) = merge
DEFAULT_INVENTORY_PLUGIN_PATH(/opt/app/workload/ansible/ansible.cfg) = [u'/opt/app/workload/ansible/ansible_cust/plugins/inventory', u'/opt/app/workload/ansib
DEFAULT_MODULE_PATH(/opt/app/workload/ansible/ansible.cfg) = [u'/opt/app/workload/ansible_core/ansible/modules', u'/opt/app/workload/ansible/ansible_cust/modu
DEFAULT_MODULE_UTILS_PATH(/opt/app/workload/ansible/ansible.cfg) = [u'/opt/app/workload/ansible/ansible_cust/module_utils', u'/opt/app/workload/ansible_core/a
DEFAULT_ROLES_PATH(/opt/app/workload/ansible/ansible.cfg) = [u'/opt/app/workload/ansible/roles', u'/opt/app/workload/ansible/passwords']
HOST_KEY_CHECKING(/opt/app/workload/ansible/ansible.cfg) = False
INVENTORY_ENABLED(/opt/app/workload/ansible/ansible.cfg) = [u'test_inv', u'host_list', u'script', u'yaml', u'ini', u'auto']

OS / ENVIRONMENT

Linux Redhat Enterprise 6 & 7, Windows 2016

STEPS TO REPRODUCE

Set fact_path in ansible.cfg to any linux path and run a task on a windows host.

EXPECTED RESULTS

Task skips local facts gathering on windows like it does on Linux

ACTUAL RESULTS

Windows Gather Facts fails

TASK [Gathering Facts] *********************************************************
fatal: [*******]: FAILED! => {"ansible_facts": {}, "changed": false, "msg": "The path /opt/app/workload/tspace/facts does not exist. Typo?"}
to retry, use: --limit @/opt/app/workload/ansible/plays/testAsync.retry

[ansibot]

Files identified in the description:

• lib/ansible/modules/system/locale_gen.py

If these files are inaccurate, please update the component name section of the description or use the !component bot command.

click here for bot help

[ansibot]

cc @AugustusKling
click here for bot help

[ansibot]

Files identified in the description:

• lib/ansible/modules/system/setup.py

If these files are inaccurate, please update the component name section of the description or use the !component bot command.

click here for bot help

[StephenGevers]

!component=lib/ansible/modules/windows/setup.ps1

[ansibot]

Files identified in the description:

• lib/ansible/modules/windows/setup.ps1

If these files are inaccurate, please update the component name section of the description or use the !component bot command.

click here for bot help

[ansibot]

cc @ShachafGoldstein @if-meaton @jborean93 @jhawkesworth @nitzmahone
click here for bot help