Skip to content
This repository has been archived by the owner on May 20, 2024. It is now read-only.

Ignore test/sanity/pep8/legacy-files.txt for test_pull_requests label #629

Closed
mattclay opened this issue Jul 6, 2017 · 2 comments
Closed

Comments

@mattclay
Copy link
Member

mattclay commented Jul 6, 2017

If test/sanity/pep8/legacy-files.txt is the only test/ file modified by a PR, the bot should not apply the test_pull_requests label. This will avoid adding the test_pull_requests label when a PR only cleans up legacy PEP 8 issues without making any other test related changes.

This request came out of discussion from the TWG.

See: ansible/community#114 (comment)

@pilou-
Copy link
Contributor

pilou- commented Jul 16, 2017

I would be nice if the bot didn't consider that any deletions of test/sanity/*/*.txt files were changes to other files in the PR. It seems that this classification prevent automerge.

@mattclay
Copy link
Member Author

mattclay commented Jan 4, 2018

This has been implemented.

@mattclay mattclay closed this as completed Jan 4, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants