Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DOCS] AWX site tab misses icon #14591

Closed
5 of 11 tasks
Andersson007 opened this issue Oct 19, 2023 · 10 comments
Closed
5 of 11 tasks

[DOCS] AWX site tab misses icon #14591

Andersson007 opened this issue Oct 19, 2023 · 10 comments

Comments

@Andersson007
Copy link
Contributor

Please confirm the following

  • I agree to follow this project's code of conduct.
  • I have checked the current issues for duplicates.
  • I understand that AWX is open source software provided for free and that I might not receive a timely response.
  • I am NOT reporting a (potential) security vulnerability. (These should be emailed to security@ansible.com instead.)

Bug Summary

I don't know how this kind of icon is properly called but it's missed on AWX docsite tabs in Chrome and Firefox at least and it doesn't look mature:)

See the screenshot
Screenshot from 2023-10-19 13-17-25

AWX version

latest

Select the relevant components

  • UI
  • UI (tech preview)
  • API
  • Docs
  • Collection
  • CLI
  • Other

Installation method

kubernetes

Modifications

no

Ansible version

No response

Operating system

No response

Web browser

Firefox, Chrome

Steps to reproduce

Open https://ansible.readthedocs.io/projects/awx/en/latest/quickstart/index.html

Expected results

it has a picture

Actual results

It doesn't have any picture

Additional information

No response

@Bhanuteja01
Copy link
Contributor

@Andersson007 can you assign me this issue
I would like work on this issue

@gundalow
Copy link
Contributor

Please copy from https://github.com/ansible/awx/blob/devel/awx/ui/public/static/media/favicon.ico into the docs directory, thanks.

@Bhanuteja01
Copy link
Contributor

@gundalow small request can add hackoctoberfest tag for this issue

@gundalow gundalow added the Hacktoberfest Issues tagged for Hacktoberfest label Oct 23, 2023
@Bhanuteja01
Copy link
Contributor

@gundalow can you explain how to do it
i tried but i not able to figure it out .can you help me in this.

@webknjaz
Copy link
Member

This is not an easy issue. The problem only appears on URL subpaths (so https://awx.rtfd.io works, for example).

Upgrading Sphinx will likely fix this, based on the comparison of https://readthedocs.org/projects/awx/builds/22558930/, https://readthedocs.org/projects/receptor/builds/22486603/ and https://readthedocs.org/projects/stage-ansible-core/builds/22549592/.

As a bonus, it'd be useful to split the tox command into two in the RTD config — tox -e docs --notest -v followed by tox -e docs --skip-pkg-install -q.

@gundalow
Copy link
Contributor

@Bhanuteja01 I'll unassign you from this. I appreciate you taking the time to look at it.

@webknjaz Thank you for providing info on how to fix this.

@Bhanuteja01
Copy link
Contributor

@gundalow already i created pr

@oraNod
Copy link
Collaborator

oraNod commented Nov 16, 2023

FYI that I've sent a PR to upgrade sphinx and the other doc requirements, which does seem to fix the issue, judging from the RTD PR preview build.

On a side note we held off on the version upgrades until the API reference docs were integrated so we could be certain the upgrade wouldn't break anything.

@tvo318
Copy link
Member

tvo318 commented Nov 20, 2023

This has now been fixed per PR #14669

@tvo318 tvo318 closed this as completed Nov 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants