Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TODO] Check the compatibility with Cython 3 #537

Closed
webknjaz opened this issue Nov 24, 2023 · 4 comments
Closed

[TODO] Check the compatibility with Cython 3 #537

webknjaz opened this issue Nov 24, 2023 · 4 comments
Assignees
Labels
help wanted Extra attention is needed

Comments

@webknjaz
Copy link
Member

Cython 3 has been stable for some time. We've been using v0.29.32 for building the wheels for release previously. #532 switched to v3.0.5.

Here's the differences to check: https://cython.readthedocs.io/en/latest/src/userguide/migrating_to_cy30.html.

@webknjaz webknjaz added the help wanted Extra attention is needed label Nov 24, 2023
@webknjaz
Copy link
Member Author

@Qalthos could you confirm that none of the differences listed on that page matter to us?

@Qalthos
Copy link
Collaborator

Qalthos commented Nov 27, 2023

I gave it a look over when I made the change, but I can give it another pass to make sure

@Qalthos
Copy link
Collaborator

Qalthos commented Nov 27, 2023

I'm closing this as complete. The only two changes that could impact us at all are

  • Python 3 syntax by default
  • Changes to function binding

The former doesn't matter for us as we have been using Python 3 syntax since the start, and don't compile to Python 2 where weirdness might leak out. A quick perusal indicates that the very few literal strings we use that are not exception messages or dictionary keys are all properly encoded or decoded as appropriate.

The latter shouldn't affect us at all as far as I can tell.

The rest of the document is talking about things we simply do not use anywhere in the library.

@Qalthos Qalthos closed this as completed Nov 27, 2023
@webknjaz
Copy link
Member Author

Great, thanks for checking!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants