Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: remove support for doc deploy index #582

Merged
merged 15 commits into from
Sep 25, 2024
Merged

feat: remove support for doc deploy index #582

merged 15 commits into from
Sep 25, 2024

Conversation

Revathyvenugopal162
Copy link
Contributor

@Revathyvenugopal162 Revathyvenugopal162 commented Sep 25, 2024 •
edited
Loading

BREAKING CHANGE: depreciate meilisearch and use the latest stable search

WIP: should be merge after release of ansys sphinx theme 1.1
fix #574

@Revathyvenugopal162
feat: remove support for doc deploy index
fb3800e 
BREAKING CHANGE: depreciate meilisearch and use the latest stable search
@ansys-reviewer-bot
Copy link
Contributor

Thanks for opening a Pull Request. If you want to perform a review write a comment saying:

@ansys-reviewer-bot review

@github-actions github-actions bot added the bug Defects or glitches reported by users or developers label Sep 25, 2024
jorgepiloto
jorgepiloto approved these changes Sep 25, 2024
View reviewed changes
Copy link
Member

@jorgepiloto jorgepiloto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah!

@jorgepiloto
Copy link
Member

jorgepiloto commented Sep 25, 2024 •
edited
Loading

I think we can merge this in main, but we need to make sure that before releasing v8 we have released ansys-sphinx-theme==1.1, is that right, @Revathyvenugopal162?

@Revathyvenugopal162
Copy link
Contributor Author

I think we can merge this in main, but we need to make sure that before releasing v8 we have released ansys-sphinx-theme==1.1, is that right, @Revathyvenugopal162?

yes that is right.

@github-actions github-actions bot added ci Pipelines maintenance related fix Pull requests related to resolving problems or errors docs Issues related to documentation labels Sep 25, 2024
@Revathyvenugopal162 Revathyvenugopal162 marked this pull request as ready for review September 25, 2024 12:08
@Revathyvenugopal162 Revathyvenugopal162 requested a review from a team as a code owner September 25, 2024 12:08
@jorgepiloto jorgepiloto merged commit 9ede620 into main Sep 25, 2024
15 checks passed
@jorgepiloto jorgepiloto deleted the fix/depreciate-meilisearch-doc-index branch September 25, 2024 12:38
@Revathyvenugopal162 Revathyvenugopal162 mentioned this pull request Sep 30, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jorgepiloto jorgepiloto jorgepiloto approved these changes

Assignees
No one assigned
Labels
bug Defects or glitches reported by users or developers ci Pipelines maintenance related docs Issues related to documentation fix Pull requests related to resolving problems or errors
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Deprecate MeiliSearch and remove doc deploy index action
2 participants
@Revathyvenugopal162 @jorgepiloto