Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Supporting open curves/sketches on revolve_sketch method #1321

Open
2 tasks done
agvarghe opened this issue Jul 22, 2024 · 1 comment
Open
2 tasks done

Supporting open curves/sketches on revolve_sketch method #1321

agvarghe opened this issue Jul 22, 2024 · 1 comment
Assignees
Labels
enhancement New features or code improvements

Comments

@agvarghe
Copy link

🔍 Before submitting the issue

  • I have searched among the existing issues
  • I am using a Python virtual environment

🐞 Description of the bug

Hi ,

When trying to generate a surface from an open curve , revolve fails

📝 Steps to reproduce

solder_barrel_sketch = Sketch(solder_barrel_plane)
solder_barrel_sketch.arc_from_start_center_and_angle(
start=Point2D([0, 0]),
center=Point2D([-0.25, 0.2918]),
angle=Angle(98.82, unit=UNITS.degrees),
clockwise=False,
)
solder_barrel = component.revolve_sketch(
"solder_barrel",
solder_barrel_sketch,
UNITVECTOR3D_Z,
Angle(360, unit=UNITS.degrees),
Point3D([0, 0, 1.0082]),
)

💻 Which operating system are you using?

Windows

📀 Which ANSYS version are you using?

2024R2

🐍 Which Python version are you using?

3.10

📦 Installed packages

Package                             Version
----------------------------------- -----------
aiohttp                             3.9.5      
aiosignal                           1.3.1      
ansys-api-dbu                       0.3.3      
ansys-api-geometry                  0.4.4      
ansys-api-meshing-prime             0.1.2.dev1 
ansys-geometry-core                 0.6.5      
ansys-meshing-prime                 0.5.0.dev10
ansys-tools-path                    0.4.0
ansys-tools-visualization-interface 0.2.6
appdirs                             1.4.4
async-timeout                       4.0.3
attrs                               23.2.0
beartype                            0.18.5
black                               24.4.2
cachetools                          5.3.2
certifi                             2023.11.17
charset-normalizer                  3.3.2
click                               8.1.7
colorama                            0.4.6
contourpy                           1.2.0
cycler                              0.12.1
fonttools                           4.46.0
frozenlist                          1.4.1
google-api-core                     2.14.0
google-api-python-client            2.109.0
google-auth                         2.24.0
google-auth-httplib2                0.1.1
googleapis-common-protos            1.61.0
grpcio                              1.59.3
grpcio-health-checking              1.48.2
httplib2                            0.22.0
idna                                3.6
kiwisolver                          1.4.5
matplotlib                          3.8.2
more-itertools                      10.3.0
msgpack                             1.0.8
multidict                           6.0.5
mypy-extensions                     1.0.0
numpy                               1.26.2
packaging                           23.2
pathspec                            0.12.1
Pillow                              10.1.0
Pint                                0.22
pip                                 23.3.1
platformdirs                        4.0.0
pooch                               1.8.0
protobuf                            3.20.3
pyasn1                              0.5.1
pyasn1-modules                      0.3.0
pyparsing                           3.1.1
python-dateutil                     2.8.2
pyvista                             0.43.10
requests                            2.31.0
rsa                                 4.9
scipy                               1.11.4
scooby                              0.9.2
semver                              3.0.2
setuptools                          65.5.0
six                                 1.16.0
tomli                               2.0.1
trame                               3.6.3
trame-client                        3.2.1
trame-server                        3.0.3
trame-vtk                           2.8.9
trame-vuetify                       2.6.1
typing_extensions                   4.8.0
uritemplate                         4.1.1
urllib3                             2.1.0
vtk                                 9.3.0
websockets                          12.0
wslink                              2.1.1
yarl                                1.9.4
@agvarghe agvarghe added the bug Something isn't working label Jul 22, 2024
@RobPasMue
Copy link
Member

Hi @agvarghe - this is expected. The method revolve_sketch only works (at the moment) with closed sketches. Implementing support for open sketches to performs a sweep operation is possible but I would not classify it as a bug. Rather as an enhancement. I am on vacations right now but I can resume work on this front once I come back.

@RobPasMue RobPasMue self-assigned this Jul 22, 2024
@RobPasMue RobPasMue added enhancement New features or code improvements and removed bug Something isn't working labels Jul 22, 2024
@RobPasMue RobPasMue changed the title Bug located in ...Revolve not supporting open curves Supporting open curves/sketches on revolve_sketch method Jul 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New features or code improvements
Projects
None yet
Development

No branches or pull requests

2 participants