Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: reactivate test on failing extra edges test #1396

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

fix: reactivate test on failing extra edges test #1396

wants to merge 3 commits into from

Conversation

RobPasMue
Copy link
Member

Description

Verifying resolution of failing test for extra edges.

Issue linked

Closes #1335

Checklist

  • I have tested my changes locally.
  • I have added necessary documentation or updated existing documentation.
  • I have followed the coding style guidelines of this project.
  • I have added appropriate unit tests.
  • I have reviewed my changes before submitting this pull request.
  • I have linked the issue or issues that are solved to the PR if any.
  • I have assigned this PR to myself.
  • I have added the minimum version decorator to any new backend method implemented.
  • I have made sure that the title of my PR follows Conventional commits style (e.g. feat: extrude circle to cylinder)

@RobPasMue RobPasMue self-assigned this Sep 3, 2024
@RobPasMue RobPasMue requested a review from a team as a code owner September 3, 2024 11:27
@RobPasMue RobPasMue linked an issue Sep 3, 2024 that may be closed by this pull request
Failing test on fixing extra edges (for Geometry Service) #1335
Open
@RobPasMue
Copy link
Member Author

@umutsoysalansys - please investigate on the server side why this test is failing and resolve. PR will test it on CI/CD.

@github-actions github-actions bot added the bug Something isn't working label Sep 3, 2024
@RobPasMue
Copy link
Member Author

Pinging @b-matteo and @smereu - this requires resolution

@RobPasMue RobPasMue mentioned this pull request Sep 3, 2024
Merged
9 tasks
@umutsoysalansys
Copy link
Contributor

umutsoysalansys commented Sep 3, 2024 •
edited
Loading

Because file is created in acis and changed as parasolid file docx. So it needs to be recreated.

@RobPasMue
Copy link
Member Author

Because file is created in acis and changed as parasolid file docx. So it needs to be recreated.

Can you recreate it and fix it @umutsoysalansys?

@umutsoysalansys
Copy link
Contributor

@umutsoysalansys - please investigate on the server side why this test is failing and resolve. PR will test it on CI/CD.

because apparently file is created in acis and saved as parasolid, or vice versa.

Because file is created in acis and changed as parasolid file docx. So it needs to be recreated.

Can you recreate it and fix it @umutsoysalansys?

I can but this is not on my priority list.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@RobPasMue RobPasMue

@umutsoysalansys umutsoysalansys

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Failing test on fixing extra edges (for Geometry Service)
3 participants
@RobPasMue @umutsoysalansys @pyansys-ci-bot