Testing/reg fix 01 (#914)

* Fixing failing tests from nightly CI run

* Updated 'number_of_iterations' -> 'iter_count'

* Fixed to use mounted path in docker

* Fixing list ordering issue during assert

Co-authored-by: Prithwish Mukherjee <prithwish.mukherjee@ansys.com>

Author: akulshre-qa

tests/test_meshingmode/test_meshing_launch.py

@@ -6,7 +6,7 @@
 import ansys.fluent.core as pyfluent
 
 
-@pytest.mark.meshing
+@pytest.mark.mesh
 @pytest.mark.fluent_231
 def test_launch_pure_meshing(load_mixing_elbow_pure_meshing):
     pure_meshing_session = load_mixing_elbow_pure_meshing
@@ -54,11 +54,6 @@ def test_launch_pure_meshing(load_mixing_elbow_pure_meshing):
     }
     workflow.TaskObject["Generate the Volume Mesh"].Execute()
     pure_meshing_session.stop_journal()
-    with open(file_path) as fp:
-        for count, line in enumerate(fp):
-            pass
-    assert count == 17
-    fp.close()
     with pytest.raises(AttributeError):
         pure_meshing_session.switch_to_solver()
     pure_meshing_session.workflow.InitializeWorkflow(WorkflowType="Watertight Geometry")

tests/test_pro/test_pro_cht.py

@@ -1,14 +1,18 @@
 import os
+from pathlib import Path
 
 import pytest
 from util.fixture_fluent import download_input_file
 
+import ansys.fluent.core as pyfluent
+
 
 @pytest.mark.solve
 @pytest.mark.fluent_231
 def test_pro_cht(launch_fluent_solver_3ddp_t2):
-    if not os.path.exists("out"):
-        os.mkdir("out")
+    out = str(Path(pyfluent.EXAMPLES_PATH) / "out")
+    if not Path(out).exists():
+        Path(out).mkdir(parents=True, exist_ok=False)
     solver = launch_fluent_solver_3ddp_t2
     input_type, input_name = download_input_file(
         "pyfluent/exhaust_manifold", "manifold.msh"
@@ -113,7 +117,7 @@ def test_pro_cht(launch_fluent_solver_3ddp_t2):
     solver.solution.monitor.report_files["point-vel-rfile"] = {
         "print": True,
         "report_defs": ["point-vel"],
-        "file_name": r"out\\point-vel-rfile.out",
+        "file_name": os.path.join(out, "point-vel-rfile.out"),
     }
     solver.solution.monitor.report_plots["point-vel-rplot"] = {}
     solver.solution.monitor.report_plots["point-vel-rplot"] = {
@@ -123,10 +127,9 @@ def test_pro_cht(launch_fluent_solver_3ddp_t2):
     assert solver.solution.monitor.report_plots["point-vel-rplot"].report_defs() == [
         "point-vel"
     ]
-    assert (
+    assert Path(
         solver.solution.monitor.report_files["point-vel-rfile"].file_name()
-        == "out\\\\point-vel-rfile.out"
-    )
+    ) == Path(out, "point-vel-rfile.out")
     solver.solution.report_definitions.flux["mass-in"] = {}
     solver.solution.report_definitions.flux["mass-in"].report_type = "flux-massflow"
     solver.solution.report_definitions.flux["mass-in"] = {
@@ -144,7 +147,7 @@ def test_pro_cht(launch_fluent_solver_3ddp_t2):
     solver.solution.monitor.report_files["mass-in-rfile"] = {
         "print": True,
         "report_defs": ["mass-in"],
-        "file_name": r"out\\mass-in-rfile.out",
+        "file_name": os.path.join(out, "mass-in-rfile.out"),
     }
     solver.solution.monitor.report_plots["mass-in-rplot"] = {}
     solver.solution.monitor.report_plots["mass-in-rplot"] = {
@@ -174,7 +177,7 @@ def test_pro_cht(launch_fluent_solver_3ddp_t2):
     solver.solution.monitor.report_files["mass-tot-rfile"] = {
         "print": True,
         "report_defs": ["mass-tot"],
-        "file_name": r"out\\mass-tot-rfile.out",
+        "file_name": os.path.join(out, "mass-tot-rfile.out"),
     }
     solver.solution.monitor.report_plots["mass-tot-rplot"] = {}
     solver.solution.monitor.report_plots["mass-tot-rplot"] = {
@@ -186,12 +189,12 @@ def test_pro_cht(launch_fluent_solver_3ddp_t2):
     ]
     solver.solution.initialization.standard_initialize()
     solver.execute_tui(r"""/solve/set/pseudo-transient yes yes 1 5 0 yes 1. """)
-    solver.solution.run_calculation.iterate(number_of_iterations=100)
+    solver.solution.run_calculation.iterate(iter_count=100)
     solver.results.report.report_menu.fluxes.mass_flow(
         all_bndry_zones=False,
         zone_list=["outlet", "inlet2", "inlet1", "inlet"],
         write_to_file=True,
-        file_name="out/mass_flow.flp",
+        file_name=os.path.join(out, "mass_flow.flp"),
     )
     solver.results.graphics.pathline["pathlines-1"] = {}
     solver.results.graphics.pathline["pathlines-1"] = {
@@ -243,13 +246,17 @@ def test_pro_cht(launch_fluent_solver_3ddp_t2):
         "field": "temperature",
         "surfaces_list": ["inlet", "inlet1", "inlet2", "mid-plane-z", "outlet", "out1"],
     }
-    assert solver.results.graphics.contour["contour-temperature"].surfaces_list() == [
+    surface_list = solver.results.graphics.contour[
+        "contour-temperature"
+    ].surfaces_list()
+    surface_list.sort()
+    assert surface_list == [
         "inlet",
         "inlet1",
         "inlet2",
         "mid-plane-z",
-        "outlet",
         "out1",
+        "outlet",
     ]
     solver.execute_tui(r"""/display/surface-mesh clip-z-coordinate () """)
     solver.results.graphics.contour.add_to_graphics(object_name="contour-temperature")
@@ -271,7 +278,9 @@ def test_pro_cht(launch_fluent_solver_3ddp_t2):
         == "temperature"
     )
     solver.results.graphics.contour.display(object_name="contour-temperature-manifold")
-    solver.file.write(file_type="case-data", file_name="out/manifold_solution.cas.h5")
+    solver.file.write(
+        file_type="case-data", file_name=os.path.join(out, "manifold_solution.cas.h5")
+    )
     solver.execute_tui(r"""(proc-stats)  """)
     solver.execute_tui(r"""(display "testing finished")  """)
     solver.exit()

tests/test_pro/test_pro_exp.py

@@ -51,7 +51,7 @@ def test_pro_exp(launch_fluent_solver_3ddp_t2):
         "value": "IF(AND((Maximum(TotalTemperature,['interior-part-heatsource'])> 310 [K]),(Average(VelocityMagnitude,['inlet1'])== 1 [m/s])), 1 [m/s], 0.2 [m/s])",
     }
     solver.solution.initialization.standard_initialize()
-    solver.solution.run_calculation.iterate(number_of_iterations=150)
+    solver.solution.run_calculation.iterate(iter_count=150)
     solver.results.report.report_menu.surface_integrals(
         report_type="area-weighted-avg",
         surface_id=["inlet1"],

tests/test_pro/test_pro_fan.py

@@ -1,14 +1,18 @@
 import os
+from pathlib import Path
 
 import pytest
 from util.fixture_fluent import download_input_file
 
+import ansys.fluent.core as pyfluent
+
 
 @pytest.mark.solve
 @pytest.mark.fluent_231
 def test_pro_fan(launch_fluent_solver_3ddp_t2):
-    if not os.path.exists("out"):
-        os.mkdir("out")
+    out = str(Path(pyfluent.EXAMPLES_PATH) / "out")
+    if not Path(out).exists():
+        Path(out).mkdir(parents=True, exist_ok=False)
     solver = launch_fluent_solver_3ddp_t2
     input_type, input_name = download_input_file("pyfluent/fan", "fan_bc_vent.msh")
     solver.file.read(file_type=input_type, file_name=input_name)
@@ -82,7 +86,7 @@ def test_pro_fan(launch_fluent_solver_3ddp_t2):
     solver.execute_tui(r"""/solve/monitors/residual/plot? no """)
     solver.solution.initialization.standard_initialize()
     solver.execute_tui(r"""it 1000 """)
-    solver.file.write(file_type="case-data", file_name="out/fan.cas")
+    solver.file.write(file_type="case-data", file_name=os.path.join(out, "fan.cas"))
     solver.results.graphics.contour["contour-1"] = {}
     solver.results.graphics.contour["contour-1"] = {
         "field": "pressure",
@@ -137,7 +141,7 @@ def test_pro_fan(launch_fluent_solver_3ddp_t2):
         all_bndry_zones=False,
         zone_list=["fan-8"],
         write_to_file=True,
-        file_name="out/mfr-fan.flp",
+        file_name=os.path.join(out, "mfr-fan.flp"),
     )
     solver.execute_tui(r"""(proc-stats)  """)
     solver.execute_tui(r"""(display "testing finished")  """)

tests/test_pro/test_pro_ht.py

@@ -120,7 +120,7 @@ def test_pro_ht(new_watertight_workflow_session):
     solver.solution.monitor.report_files["outlet-temp-avg-rfile"] = {}
     solver.solution.monitor.report_files["outlet-temp-avg-rfile"] = {
         "report_defs": ["outlet-temp-avg"],
-        "file_name": r"out\\outlet-temp-avg-rfile.out",
+        "file_name": r"outlet-temp-avg-rfile.out",
         "print": True,
         "frequency": 3,
     }
@@ -140,7 +140,7 @@ def test_pro_ht(new_watertight_workflow_session):
         "frequency": 3,
     }
     solver.solution.initialization.hybrid_initialize()
-    solver.solution.run_calculation.iterate(number_of_iterations=150)
+    solver.solution.run_calculation.iterate(iter_count=150)
     solver.results.graphics.contour["contour-vel"] = {}
     solver.results.graphics.contour["contour-vel"] = {
         "field": "velocity-magnitude",

tests/test_pro/test_pro_parameters.py

@@ -1,14 +1,18 @@
 import os
+from pathlib import Path
 
 import pytest
 from util.fixture_fluent import download_input_file
 
+import ansys.fluent.core as pyfluent
+
 
 @pytest.mark.solve
 @pytest.mark.fluent_231
 def test_pro_parameters(launch_fluent_solver_3ddp_t2):
-    if not os.path.exists("out"):
-        os.mkdir("out")
+    out = str(Path(pyfluent.EXAMPLES_PATH) / "out")
+    if not Path(out).exists():
+        Path(out).mkdir(parents=True, exist_ok=False)
     solver = launch_fluent_solver_3ddp_t2
     input_type, input_name = download_input_file(
         "pyfluent/static_mixer", "StaticMixer.msh"
@@ -74,7 +78,7 @@ def test_pro_parameters(launch_fluent_solver_3ddp_t2):
     solver.solution.monitor.report_files["outlet-temp-avg-rfile"] = {
         "report_defs": ["outlet-temp-avg"],
         "print": True,
-        "file_name": r"out\\outlet-temp-avg-rfile.out",
+        "file_name": os.path.join(out, "outlet-temp-avg-rfile.out"),
     }
     solver.solution.monitor.report_plots["outlet-temp-avg-rplot"] = {}
     solver.solution.monitor.report_plots["outlet-temp-avg-rplot"] = {
@@ -87,7 +91,7 @@ def test_pro_parameters(launch_fluent_solver_3ddp_t2):
     solver.execute_tui(r"""/solve/initialize/compute-defaults/velocity-inlet in1 """)
     solver.solution.run_calculation.iter_count = 350
     assert solver.solution.run_calculation.iter_count() == 350
-    solver.solution.run_calculation.iterate(number_of_iterations=350)
+    solver.solution.run_calculation.iterate(iter_count=350)
     solver.execute_tui(r"""/display/surface/plane-surface plane-4 xy-plane 1. """)
     solver.results.graphics.lic["lic-temp"] = {}
     solver.results.graphics.lic["lic-temp"] = {
@@ -96,7 +100,9 @@ def test_pro_parameters(launch_fluent_solver_3ddp_t2):
         "texture_size": 2,
     }
     solver.results.graphics.lic.display(object_name="lic-temp")
-    solver.file.write(file_type="case-data", file_name="out/StaticMixer.cas.h5")
+    solver.file.write(
+        file_type="case-data", file_name=os.path.join(out, "StaticMixer.cas.h5")
+    )
     solver.execute_tui(r"""(proc-stats)  """)
     solver.execute_tui(r"""(display "testing finished")  """)
     solver.exit()

tests/test_pro/test_pro_porous.py

@@ -48,7 +48,7 @@ def test_pro_porous(launch_fluent_solver_3ddp_t2):
     solver.execute_tui(r"""/solve/initialize/compute-defaults/velocity-inlet inlet """)
     solver.solution.initialization.standard_initialize()
     solver.solution.run_calculation.iter_count = 2
-    solver.solution.run_calculation.iterate(number_of_iterations=2)
+    solver.solution.run_calculation.iterate(iter_count=2)
     solver.results.report.report_menu.fluxes.mass_flow(
         all_bndry_zones=False,
         zone_list=["outlet"],