Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: checking port on non-grpc mapdl instances #3540

Merged
merged 2 commits into from
Nov 7, 2024
Merged

Conversation

germa89
Copy link
Collaborator

@germa89 germa89 commented Nov 6, 2024

Description

As the title.

Issue linked

Close #3539

Checklist

@germa89 germa89 self-assigned this Nov 6, 2024
@germa89 germa89 requested a review from a team as a code owner November 6, 2024 13:18
@germa89 germa89 requested review from clatapie and pyansys-ci-bot and removed request for a team November 6, 2024 13:18
@ansys-reviewer-bot
Copy link
Contributor

Thanks for opening a Pull Request. If you want to perform a review write a comment saying:

@ansys-reviewer-bot review

@github-actions github-actions bot added the bug Issue, problem or error in PyMAPDL label Nov 6, 2024
Copy link

codecov bot commented Nov 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.46%. Comparing base (21e52c8) to head (39308ba).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3540      +/-   ##
==========================================
- Coverage   87.46%   87.46%   -0.01%     
==========================================
  Files          58       58              
  Lines       10214    10217       +3     
==========================================
+ Hits         8934     8936       +2     
- Misses       1280     1281       +1     

@germa89
Copy link
Collaborator Author

germa89 commented Nov 7, 2024

@pyansys-ci-bot LGTM.

@germa89 germa89 enabled auto-merge (squash) November 7, 2024 10:28
Copy link
Contributor

@pyansys-ci-bot pyansys-ci-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Approving this PR because germa89 said so in here 😬

LGTM

@germa89 germa89 merged commit baa7ac0 into main Nov 7, 2024
62 checks passed
@germa89 germa89 deleted the fix--port-not-in-cmd branch November 7, 2024 10:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Issue, problem or error in PyMAPDL
Projects
None yet
Development

Successfully merging this pull request may close these issues.

-port not found in pymapdl list
2 participants