Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

增加 @ant-design/pro-layout 的提示 #61

Closed
afc163 opened this issue Feb 20, 2020 · 11 comments
Closed

增加 @ant-design/pro-layout 的提示 #61

afc163 opened this issue Feb 20, 2020 · 11 comments
Assignees

Comments

@afc163
Copy link
Member

afc163 commented Feb 20, 2020

提示用户升级到 5.0。

@chenshuai2144
Copy link

API 是兼容的,提示升级即可。

@vagusX
Copy link
Member

vagusX commented Feb 21, 2020

API 是兼容的,提示升级即可。

只有 pro-layout 一个包需要提示吗?

@afc163
Copy link
Member Author

afc163 commented Feb 21, 2020

@ant-design/icons 也额外检查一下吧,发现有的用户项目里有 @ant-design/icons@2.x 的依赖。

@afc163
Copy link
Member Author

afc163 commented Feb 26, 2020

@alipay/tech-ui 也可以检测一下,具体版本咨询一下兼续。

@vagusX
Copy link
Member

vagusX commented Feb 28, 2020

这里有个问题,就是可能用户当前的 cwd 不一定有 package.json,或者传入的目标 cwd 不一定有 package.json 目前只能去嗅探这两个目录,及之间的目录是否存在 package.json,并进行检测和提示

看到有个社区包可以找到最近位置的 package.json,打算通过这个来实现 https://github.com/sindresorhus/pkg-up

@zombieJ
Copy link
Member

zombieJ commented Feb 28, 2020

个人感觉根目录检测 package.json 应该是够了。再多想不到什么场景了。

@vagusX
Copy link
Member

vagusX commented Feb 28, 2020

最终方案:通过 read-pkg-up 读取 process.cwd() + targetPath 后的 path string 下最近的 package.json 进行检测

@vagusX
Copy link
Member

vagusX commented Feb 28, 2020

// bin/upgrade-list.json
{
  "@ant-design/pro-layout": {
    "version": "5.0.0"
  },
  "@ant-design/icons": {
    "version": "4.0.0"
  }
}

后续这个只需要把 json 更新即可 @afc163 @zombieJ

@vagusX vagusX assigned vagusX and unassigned chenshuai2144 Feb 28, 2020
@chenshuai2144
Copy link

@alipay/tech-ui@1.14.0
今天刚发布的版本,搞完真是太难了

@vagusX
Copy link
Member

vagusX commented Mar 1, 2020

@alipay/tech-ui@1.14.0
今天刚发布的版本,搞完真是太难了

所以 tech-ui 就是提示升级到 ^1.14.0 即可?

@rdmclin2
Copy link
Member

rdmclin2 commented Mar 1, 2020

{
  "@alipay/techui-form": {
    "version": "2.2.1"
  },
  "@alipay/tech-ui": {
    "version": "1.14.0"
  }
}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants