Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove antler run #231

Merged
merged 16 commits into from
Sep 27, 2023
Merged

Remove antler run #231

merged 16 commits into from
Sep 27, 2023

Conversation

dimas1185
Copy link
Contributor

@dimas1185 dimas1185 commented Sep 21, 2023

this partial resolution of #206

Current state of Antler run in main branch is just empty binary. Most up to date work on Antler run can be found in https://github.com/AntelopeIO/cdt/tree/antler-run branch. On this point we are stopping any further development of Antler run and removing all its parts from main branch.

Change Description

API Changes

  • API Changes

Documentation Additions

  • Documentation Additions

@ericpassmore
Copy link
Contributor

Do we need to update the top level CMakeLists.txt?

cdt/CMakeLists.txt

Lines 96 to 106 in f897dc7

configure_file(${CMAKE_SOURCE_DIR}/tools/external/antler-proj/LICENSE ${CMAKE_BINARY_DIR}/licenses/antler-proj.license COPYONLY)
file(GLOB license_files ${CMAKE_SOURCE_DIR}/tools/external/antler-proj/licenses/*)
# add licenses for antler-proj submodules
foreach(full_path IN ITEMS ${license_files})
# change format to match other license filenames
get_filename_component(file_name ${full_path} NAME)
string(REPLACE "LICENSE." "" file_name ${file_name})
string(TOLOWER ${file_name} file_name)
set(file_name "${file_name}.license")
configure_file("${full_path}" "${CMAKE_BINARY_DIR}/licenses/${file_name}" COPYONLY)
endforeach()

@ericpassmore
Copy link
Contributor

Should we update modules/InstallCDT.cmake

cdt_tool_install_and_symlink(antler-proj antler-proj)

@ericpassmore
Copy link
Contributor

Should we remove from scripts/generate_tarball.sh

create_symlink antler-proj antler-proj
create_symlink antler-proj cdt-proj

@dimas1185
Copy link
Contributor Author

Do we need to update the top level CMakeLists.txt?

cdt/CMakeLists.txt

Lines 96 to 106 in f897dc7

configure_file(${CMAKE_SOURCE_DIR}/tools/external/antler-proj/LICENSE ${CMAKE_BINARY_DIR}/licenses/antler-proj.license COPYONLY)
file(GLOB license_files ${CMAKE_SOURCE_DIR}/tools/external/antler-proj/licenses/*)
# add licenses for antler-proj submodules
foreach(full_path IN ITEMS ${license_files})
# change format to match other license filenames
get_filename_component(file_name ${full_path} NAME)
string(REPLACE "LICENSE." "" file_name ${file_name})
string(TOLOWER ${file_name} file_name)
set(file_name "${file_name}.license")
configure_file("${full_path}" "${CMAKE_BINARY_DIR}/licenses/${file_name}" COPYONLY)
endforeach()

this PR is to remove Antler RUN. You are commenting Antler PROJ which is different part and I'll do this with a separate PR.

Copy link
Contributor

@ericpassmore ericpassmore left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dimas1185 dimas1185 merged commit 359f483 into main Sep 27, 2023
@dimas1185 dimas1185 deleted the remove-antler-run branch September 27, 2023 20:04
@ericpassmore ericpassmore mentioned this pull request Oct 4, 2023
2 tasks
@ericpassmore
Copy link
Contributor

Note:start
group: RELEASE
category: CHORE
summary: Remove unused antler run packed with CDT binaries.
Note:end

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants