Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[5.0] Better error reporting on snapshot load exceptions #2294

Merged
merged 1 commit into from
Mar 8, 2024

Conversation

heifner
Copy link
Member

@heifner heifner commented Mar 8, 2024

./nodeos --data-dir dd --config-dir mainconfig --snapshot snapshot-2024-02-08-04-eos-v6-0356339018.bin.zst

Before:

warn  2024-03-08T13:37:03.489 nodeos    chain_plugin.cpp:1102         plugin_initialize    ] 3240000 snapshot_exception: Snapshot exception
Binary snapshot validation threw IO exception (Snapshot exception)
    {"what":"Snapshot exception"}
    nodeos  snapshot.cpp:261 validate

appbase: exception thrown during plugin "" initialization.
Snapshot exception

With this PR:

warn  2024-03-08T13:39:02.560 nodeos    snapshot.cpp:260              validate             ] 3240000 snapshot_exception: Snapshot exception
Binary snapshot has unexpected magic number!
    {}
    nodeos  snapshot.cpp:249 validate

warn  2024-03-08T13:39:02.561 nodeos    chain_plugin.cpp:1102         plugin_initialize    ] 3240000 snapshot_exception: Snapshot exception
Binary snapshot has unexpected magic number!
    {}
    nodeos  snapshot.cpp:249 validate
rethrow
    {}
    nodeos  snapshot.cpp:260 validate

appbase: exception thrown during plugin "" initialization.
Snapshot exception

Resolves #2293

@heifner heifner requested review from spoonincode and greg7mdp March 8, 2024 13:43
@heifner heifner added the OCI Work exclusive to OCI team label Mar 8, 2024
@heifner heifner linked an issue Mar 8, 2024 that may be closed by this pull request
@heifner heifner merged commit b4dc3b6 into release/5.0 Mar 8, 2024
29 checks passed
@heifner heifner deleted the GH-2293-snapshot-error branch March 8, 2024 16:27
@ericpassmore
Copy link
Contributor

Note:start
group: CLEANCODE
category: INTERNALS
summary: More verbose error reporting on snapshot load exceptions.
Note:end

@ericpassmore
Copy link
Contributor

Note:start
category: Logging
component: Internal
summary: More verbose error reporting on snapshot load exceptions.
Note:end

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
OCI Work exclusive to OCI team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Better error reporting on snapshot failure
4 participants