resurrect compiler_builtins_tests for compiler builtins host functions
#640
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Bucky Kittinger <larrykittinger@gmail.com>
spoonincode
commented
Aug 26, 2024
|
|
||
| #include "test_api.hpp" | ||
|
|
||
| //these are no longer exposed in cdt |
There was a problem hiding this comment.
Similarly, we need to explicitly call the host functions so we know we're actually testing the host functions. It's possible future cdt versions won't ever implicitly call the host functions given something like
__int128 a = 0, b = 0;
a/b;
greg7mdp
approved these changes
Aug 26, 2024
heifner
approved these changes
Aug 26, 2024
|
Note:start |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resurrect
compiler_builtins_testsremoved in bedf133. This test is exercising host functions in spring so it does belong here in spring. Removal of these tests lost coverage for host function behavior such asspring/libraries/chain/webassembly/compiler_builtins.cpp
Line 46 in 22d9892
(afaict anyways, maybe there is some other test somewhere I missed)