Optimize block processing - Part 2 #688
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…block instead of through chain_plugin. Remove unused block_sync in chain_plugin. Remove unneeded code from net_plugin and producer_plugin now that blocks are not processed one at a time.
|
Note:start |
…block-processing-part2
…block-processing-part2
…block-processing-part2
linh2931
reviewed
Sep 18, 2024
…' into GH-529-optimize-block-processing-part2
…ead has been updated. Fix off by one error in call to is_sync_request_ahead_allowed. Work-around accepted_block not called until block is irreversible in irreversible mode.
linh2931
reviewed
Sep 20, 2024
greg7mdp
requested changes
Sep 23, 2024
…for irreversible to make it clearer.
…' into GH-529-optimize-block-processing-part2
greg7mdp
approved these changes
Sep 23, 2024
linh2931
approved these changes
Sep 24, 2024
…block-processing-part2
…block-processing-part2
linh2931
approved these changes
Sep 26, 2024
This was referenced Mar 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part 2 of 3 of #529. See #619 for part 1.
This PR only notifies producer plugin that a new incoming block is ready to be processed instead of notifying that a specific block is available.
rejected_blockchannel. If needed in the future this will need to be a signal out of controller instead of a channel.voted_blockchannel. There is a controller signal for this and the channel was not used.on_incoming_blocknotifications directly toproducer_plugininstead of routing through thechain_plugin. I think this makes the code easier to understand.sync_recv_blockto be called fromon_accepted_blockfor tracking applied blocks.net_plugin.Partially resolves #529