Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Failed to parse a breaking change commit with a scope #60

Closed
7 tasks done
ntnyq opened this issue Dec 7, 2024 · 0 comments · Fixed by #61
Closed
7 tasks done

Failed to parse a breaking change commit with a scope #60

ntnyq opened this issue Dec 7, 2024 · 0 comments · Fixed by #61

Comments

@ntnyq
Copy link

ntnyq commented Dec 7, 2024

Describe the bug

printCommits failed to parse a breaking change commit with a scope.

const match = message.match(/^(\w+)(!)?(\([^)]+\))?:(.*)$/)

The regexp only match the ! after tag, but not scope.

Reproduction

https://github.com/ntnyq-dev/repro-bumpp-parse-breaking-commits

System Info

System:
    OS: macOS 14.5
    CPU: (10) arm64 Apple M1 Pro
    Memory: 220.55 MB / 16.00 GB
    Shell: 5.9 - /bin/zsh
  Binaries:
    Node: 22.12.0 - ~/.local/state/fnm_multishells/60906_1733597804989/bin/node
    Yarn: 1.22.22 - ~/.yarn/bin/yarn
    npm: 10.9.0 - ~/.local/state/fnm_multishells/60906_1733597804989/bin/npm
    pnpm: 9.15.0 - ~/Library/pnpm/pnpm
    bun: 1.1.34 - ~/.bun/bin/bun
  Browsers:
    Chrome: 131.0.6778.109
    Edge: 131.0.2903.86
    Safari: 17.5

Used Package Manager

pnpm

Validations

  • Follow our Code of Conduct
  • Read the Contributing Guide.
  • Check that there isn't already an issue that reports the same bug to avoid creating a duplicate.
  • Check that this is a concrete bug. For Q&A, please open a GitHub Discussion instead.
  • The provided reproduction is a minimal reproducible of the bug.

Contributions

  • I am willing to submit a PR to fix this issue
  • I am willing to submit a PR with failing tests (actually just go ahead and do it, thanks!)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant