fix: url version should be exclude from upgrading (#177)

Co-authored-by: Anthony Fu <github@antfu.me>

Author: yyz945947732

src/io/dependencies.ts

@@ -27,8 +27,13 @@ export function setByPath(obj: any, path: string, value: any) {
   target[lastKey] = value
 }
 
-export function parseDependencies(pkg: any, type: DepType, shouldUpdate: (name: string) => boolean): RawDep[] {
-  return Object.entries(getByPath(pkg, type) || {}).map(([name, { version, parents }]) => parseDependency(name, version, type, shouldUpdate, parents))
+export function parseDependencies(
+  pkg: any,
+  type: DepType,
+  shouldUpdate: (name: string) => boolean,
+): RawDep[] {
+  return Object.entries(getByPath(pkg, type) || {})
+    .map(([name, { version, parents }]) => parseDependency(name, version, type, shouldUpdate, parents))
 }
 
 export function parseDependency(name: string, version: string, type: DepType, shouldUpdate: (name: string) => boolean, parents?: string[]): RawDep {

src/io/resolves.ts

@@ -181,7 +181,7 @@ export async function resolveDependency(
         ? optionMode
         : optionMode === 'default' ? configMode : 'ignore'
     : optionMode
-  if (isLocalPackage(raw.currentVersion) || !raw.update || !await Promise.resolve(filter(raw)) || mergeMode === 'ignore') {
+  if (isLocalPackage(raw.currentVersion) || isUrlPackage(raw.currentVersion) || !raw.update || !await Promise.resolve(filter(raw)) || mergeMode === 'ignore') {
     return {
       ...raw,
       diff: null,
@@ -292,17 +292,15 @@ export async function resolvePackage(pkg: PackageMeta, options: CheckOptions, fi
   return pkg
 }
 
-function isLocalPackage(currentVersion: string) {
-  const localPackagePrefix = [
-    'link:',
-    'file:',
-    'workspace:',
-    'catalog:',
-  ]
-  return localPackagePrefix.some(prefix => currentVersion.startsWith(prefix))
+export function isUrlPackage(currentVersion: string) {
+  return /^(?:https?:|git\+|github:)/.test(currentVersion)
 }
 
-function isAliasedPackage(currentVersion: string) {
+export function isLocalPackage(currentVersion: string) {
+  return /^(?:link|file|workspace|catalog):/.test(currentVersion)
+}
+
+export function isAliasedPackage(currentVersion: string) {
   return currentVersion.startsWith('npm:')
 }
 

test/parseDependencies.test.ts

@@ -1,5 +1,6 @@
 import { describe, expect, it } from 'vitest'
 import { parseDependencies } from '../src/io/dependencies'
+import { isLocalPackage, isUrlPackage } from '../src/io/resolves'
 
 describe('parseDependencies', () => {
   it('parse package `dependencies`', () => {
@@ -62,6 +63,90 @@ describe('parseDependencies', () => {
       `)
   })
 
+  it('parse package `dependencies` should exclude URL version', () => {
+    const myPackage = {
+      name: '@taze/package1',
+      private: true,
+      dependencies: {
+        '@taze/not-exists': '^4.13.19',
+        '@typescript/lib-dom': 'npm:@types/web@^0.0.80',
+        'my-lib1': 'https://example.com/packages/my-lib1-1.0.0.tgz',
+        'my-lib2': 'git+https://github.com/user/my-lib2.git',
+        'my-lib3': 'github:user/my-lib3#v1.2.3',
+        'my-lib4': 'file:../my-lib4',
+      },
+    }
+    const result = parseDependencies(myPackage, 'dependencies', () => true)
+    expect(result).toMatchInlineSnapshot(`
+      [
+        {
+          "currentVersion": "^4.13.19",
+          "name": "@taze/not-exists",
+          "parents": [],
+          "source": "dependencies",
+          "update": true,
+        },
+        {
+          "currentVersion": "npm:@types/web@^0.0.80",
+          "name": "@typescript/lib-dom",
+          "parents": [],
+          "source": "dependencies",
+          "update": true,
+        },
+        {
+          "currentVersion": "https://example.com/packages/my-lib1-1.0.0.tgz",
+          "name": "my-lib1",
+          "parents": [],
+          "source": "dependencies",
+          "update": true,
+        },
+        {
+          "currentVersion": "git+https://github.com/user/my-lib2.git",
+          "name": "my-lib2",
+          "parents": [],
+          "source": "dependencies",
+          "update": true,
+        },
+        {
+          "currentVersion": "github:user/my-lib3#v1.2.3",
+          "name": "my-lib3",
+          "parents": [],
+          "source": "dependencies",
+          "update": true,
+        },
+        {
+          "currentVersion": "file:../my-lib4",
+          "name": "my-lib4",
+          "parents": [],
+          "source": "dependencies",
+          "update": true,
+        },
+      ]
+    `)
+
+    expect(
+      result
+        .filter(i => !isUrlPackage(i.currentVersion) && !isLocalPackage(i.currentVersion)),
+    ).toMatchInlineSnapshot(`
+      [
+        {
+          "currentVersion": "^4.13.19",
+          "name": "@taze/not-exists",
+          "parents": [],
+          "source": "dependencies",
+          "update": true,
+        },
+        {
+          "currentVersion": "npm:@types/web@^0.0.80",
+          "name": "@typescript/lib-dom",
+          "parents": [],
+          "source": "dependencies",
+          "update": true,
+        },
+      ]
+    `)
+  })
+
   it('parse package `pnpm.overrides`', () => {
     const myPackage = {
       name: '@taze/package1',