fix: pass env param to config function #19
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
antfu
reviewed
May 3, 2022
src/presets.ts
Outdated
| /** | ||
| * Retwrite the config file and extract the options passed to plugin factory | ||
| * (e.g. Vite and Rollup plugins) | ||
| */ | ||
| export function sourcePluginFactory(options: SourcePluginFactoryOptions) { | ||
| export function sourcePluginFactory(options: SourcePluginFactoryOptions, env: ConfigEnv = { command: 'dev' }) { |
There was a problem hiding this comment.
This will be too specific, unconfig work not only for Vite. We should have parameters: any[] for user to pass in.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was tracing the root cause for the unocss/unocss#874 and I think the problem is here:
https://github.com/antfu/unconfig/blob/be90fdb34230e924f1f773d12d15845edb1aa2b5/src/presets.ts#L35
A quick solution would be to pass an empty object to
__unconfig_default()so the destructing would pass. I thought it would be better to make it configurable.I did a little search and it sounds like the Rollup, Svelte, and Astro configs don't mind a parameter, so this should be safe to bypass the Vite special case.