Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make browserified script below 1MB #28

Open
DavidBruant opened this issue Aug 21, 2014 · 3 comments
Open

Make browserified script below 1MB #28

DavidBruant opened this issue Aug 21, 2014 · 3 comments

Comments

@DavidBruant
Copy link
Contributor

Current browserified script is 3.2MB.

Commenting out require('socket.io-client'); removes 500k. Do we really need Socket.io (with all the fallbacks for old browsers and shit)?
Commenting out dat-gui saves 300k

We'd be at ~2.4MB which is still a lot. Need to investigate minifying.

@vallettea
Copy link
Contributor

yes i think socketio is necessary and the argument of old browser is not enough since they won't support webgl neither.

@DavidBruant
Copy link
Contributor Author

yes i think socketio is necessary

Why? For our needs, the raw WebSocket API seems to be enough.

the argument of old browser is not enough since they won't support webgl neither.

I don't understand that part. My argument is that we don't need support for old browsers which socket.io brings. You're arguing in favor of removing socket.io here.

@vallettea
Copy link
Contributor

i misunderstood i though you wanted to get rid of websocket and the comparison to three was that if you browser doesn't support websocket there are few chances it will support webgl.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants