Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set MimiFAIRv2.0 up as a package #7

Closed
FrankErrickson opened this issue Jun 8, 2021 · 1 comment
Closed

Set MimiFAIRv2.0 up as a package #7

FrankErrickson opened this issue Jun 8, 2021 · 1 comment
Labels
enhancement New feature or request

Comments

@FrankErrickson
Copy link
Collaborator

But first need to sort out what the current Mimi standards/guidelines are for model packages.

@lrennels
Copy link
Collaborator

lrennels commented Jun 30, 2021

@FrankErrickson I can handle this no problem, and have done a good amount in #8 already, but I'm not sure we can actually register it in the General Regsitry without making this repository public. For now it is set up as a registry in #8, so you can call

add https://github.com/FrankErrickson/MimiFAIRv2.0.jl.git
# or dev https://github.com/FrankErrickson/MimiFAIRv2.0.jl.git
using MimiFAIRv2.0

but you can't use

add MimiFAIRv2.0

since the name is in the General Registry.

IF we want to convert to a package, we will also need to do the following in addition with the changes I have already made in #8

  • add .gitignore/workflows files and the accompanying pkg butler .yml file
  • change the combo of include and using Main.MimiFAIRv2 to using MimiFAIRv2 in both runtests.jl and the README.md
  • register

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants