Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Python issue with import from typing #2611

Closed
ImanHosseini opened this issue Jul 27, 2019 · 1 comment · Fixed by #3067
Closed

Python issue with import from typing #2611

ImanHosseini opened this issue Jul 27, 2019 · 1 comment · Fixed by #3067

Comments

@ImanHosseini
Copy link
Contributor

ImanHosseini commented Jul 27, 2019 •
edited
Loading

Python's TextIO used to be in typing.io so you would do:

from typing.io import TextIO

Since Python 3.6, TextIO is now in typing directly so the above (which ANTLR does) would trigger an error, it should be changed to [for 3.6+]:

from typing import TextIO

(also the underlying reason for #2193)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix TextIO compatibility with Python 3.6+ in LexerFile
2 participants
@ImanHosseini @tsotnikov