Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bug(preimage): Investigate oracle reader flakes #76

Closed
clabby opened this issue Apr 3, 2024 · 3 comments
Closed

bug(preimage): Investigate oracle reader flakes #76

clabby opened this issue Apr 3, 2024 · 3 comments
Assignees
@clabby
Labels
A-preimage Area: kona-preimage crate K-bug Kind: bug M-help-wanted Meta: Extra attention is needed

Comments

@clabby
Copy link
Collaborator

clabby commented Apr 3, 2024

Overview

The oracle reader tests flaked in this workflow: https://github.com/ethereum-optimism/kona/actions/runs/8541657676/job/23401491592

Investigate the failure and fix it. Pretty sure this is just a race condition in the tokio test, though we should expect that the pipe properly blocks.
@clabby clabby added K-bug Kind: bug A-preimage Area: kona-preimage crate labels Apr 3, 2024
@clabby
Copy link
Collaborator Author

clabby commented Apr 9, 2024

Closed w/ #96

@clabby clabby closed this as completed Apr 9, 2024
@refcell refcell added this to the Life is Good milestone Apr 15, 2024
@refcell
Copy link
Collaborator

refcell commented Apr 17, 2024

Just experienced this flake again locally. Re-opening so we investigate again.

@refcell refcell reopened this Apr 17, 2024
@refcell refcell added the M-help-wanted Meta: Extra attention is needed label Apr 17, 2024
@clabby clabby self-assigned this Apr 28, 2024
@clabby clabby modified the milestones: Phase 4: Multi Program Test Suite, Phase 3: Kona Client & Host Jun 8, 2024
@clabby
Copy link
Collaborator Author

clabby commented Jun 8, 2024

Haven't seen these in a good while after the latest updates. Closing for now.

@clabby clabby closed this as completed Jun 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@clabby clabby

Labels
A-preimage Area: kona-preimage crate K-bug Kind: bug M-help-wanted Meta: Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@clabby @refcell