fix(host): Blocking native client program #201
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This stack of pull requests is managed by Graphite. Learn more about stacking. |
clabby
force-pushed
the
cl/host-termination
branch
2 times, most recently
from
331e918 to
fec70d2
Compare
refcell
reviewed
Jun 3, 2024
Makes the `HintWriterClient` + `PreimageOracleClient` traits asynchronous to prevent blocking of the host program when executing a client program natively. Previously, since the preimage oracle bindings for the client were entirely synchronous, the loops in `PipeHandle` could cause a deadlock. Now that oracle IO is asynchronous, the runtime can interrupt a future when it yields execution (i.e. `tokio::select` works.) In the client program, synchronous execution is still guaranteed. It can run async colored functions in a minimal runtime, such as the `block_on` runtime in `kona_common`. `simple-revm` had to be changed as a part of this PR, which has an example of this.
Improves the asynchronous logic in `kona-host` to handle gracefully exiting the parallel host and client threads if either throw.
clabby
force-pushed
the
cl/host-termination
branch
from
fec70d2 to
ba64257
Compare
Co-authored-by: refcell <abigger87@gmail.com>
This was referenced Jun 11, 2024
Closed
Closed
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Improves the asynchronous logic in
kona-hostto handle gracefully exiting the parallel host and client threads if either throw.Also does a bit of cleanup in the host.